[kcms/nightcolor] Minor UI tweaks to the KCM
ClosedPublic

Authored by filipf on Jul 31 2019, 9:13 PM.

Details

Summary
  • the slider is now of the same width as the comobox below it
  • the slider's value has been placed to the right of the slider, as the HIG mandates
  • use title case for "Detect Location" button
  • add an icon to the "Detect Location" button
Test Plan

Before

After

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
filipf created this revision.Jul 31 2019, 9:13 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJul 31 2019, 9:13 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
filipf requested review of this revision.Jul 31 2019, 9:13 PM
filipf edited the test plan for this revision. (Show Details)Jul 31 2019, 9:14 PM
filipf added reviewers: Plasma, VDG.
GB_2 added a subscriber: GB_2.Jul 31 2019, 9:40 PM
GB_2 added inline comments.
kcms/nightcolor/package/contents/ui/main.qml
118

Lowercase c?

filipf added inline comments.
kcms/nightcolor/package/contents/ui/main.qml
118

@romangg you wrote the feature, should we capitalize its name? :)

ngraham accepted this revision.Jul 31 2019, 11:05 PM
This revision is now accepted and ready to land.Jul 31 2019, 11:05 PM
romangg added inline comments.Aug 1 2019, 12:27 AM
kcms/nightcolor/package/contents/ui/main.qml
118

I would leave it with the capital C since it's part of the name.

zzag added a subscriber: zzag.Aug 1 2019, 9:44 AM
zzag added inline comments.
kcms/nightcolor/package/contents/ui/main.qml
118

Just my 2 cents: you can simplify this string to "Night temperature." Not sure whether translators will like this change though.

zzag added inline comments.Aug 1 2019, 9:46 AM
kcms/nightcolor/package/contents/ui/main.qml
118

but it depends on how you look at it. "Night color temperature" might be a better string. As it speaks about color temperature and not temperature of "Night Color."

GB_2 added inline comments.Aug 1 2019, 10:59 AM
kcms/nightcolor/package/contents/ui/main.qml
118

Agreed.

ngraham added inline comments.Aug 1 2019, 1:53 PM
kcms/nightcolor/package/contents/ui/main.qml
118

"Night Color" is the name of the feature itself; you can't truncate it to save a few words. I think it also needs to keep its capitalization.

If you're looking to change the string, I would focus on the word "temperature." Regular people think of "temperature" as something having to do with heat and cold, not colors. Only artists and computer experts generally understand that colors can have a temperature.

zzag added inline comments.Aug 1 2019, 2:10 PM
kcms/nightcolor/package/contents/ui/main.qml
118

There are some technical terms that should stay "technical," "color temperature" is one of those.

filipf added inline comments.Aug 1 2019, 3:29 PM
kcms/nightcolor/package/contents/ui/main.qml
118

I think using the technical term here is fine. IIRC f.lux tried to simplify this by adding a bunch of descriptors which compared a particular temperature value or even range to a lighting condition, e.g. one generated by incandescent bulbs. But I don't think we need this, users will figure it out.

Regarding using uppercase c in "Night Color", that's 2 in favor and 2 against it. We had this dilemma with "Look and Feel" before and kept "Feel" capitalized because it's the name of a specific feature I guess. I'm not super passionate about what we choose, but I slightly lean towards leaving "Color" capitalized for now. That okay?

This revision was automatically updated to reflect the committed changes.
zzag added inline comments.Aug 2 2019, 1:43 PM
kcms/nightcolor/package/contents/ui/main.qml
118

This option talks about color temperature, so lower case makes sense.

This is not a big deal, but just a little detail.

The “Apply” button stops working after the “Times” mode is activated.
Before turning on this mode, the rest works fine.
To fix, you can delete the line “Mode=Times" from the file
~/.config/kwinrc and restart the session.

https://bugs.kde.org/show_bug.cgi?id=411584