- the slider is now of the same width as the comobox below it
- the slider's value has been placed to the right of the slider, as the HIG mandates
- use title case for "Detect Location" button
- add an icon to the "Detect Location" button
Details
- Reviewers
ngraham - Group Reviewers
Plasma VDG - Commits
- R119:5c0ec75f7ce1: [kcms/nightcolor] Minor UI tweaks to the KCM
Before
After
Diff Detail
- Repository
- R119 Plasma Desktop
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
kcms/nightcolor/package/contents/ui/main.qml | ||
---|---|---|
118 | Lowercase c? |
kcms/nightcolor/package/contents/ui/main.qml | ||
---|---|---|
118 | I would leave it with the capital C since it's part of the name. |
kcms/nightcolor/package/contents/ui/main.qml | ||
---|---|---|
118 | Just my 2 cents: you can simplify this string to "Night temperature." Not sure whether translators will like this change though. |
kcms/nightcolor/package/contents/ui/main.qml | ||
---|---|---|
118 | but it depends on how you look at it. "Night color temperature" might be a better string. As it speaks about color temperature and not temperature of "Night Color." |
kcms/nightcolor/package/contents/ui/main.qml | ||
---|---|---|
118 | Agreed. |
kcms/nightcolor/package/contents/ui/main.qml | ||
---|---|---|
118 | "Night Color" is the name of the feature itself; you can't truncate it to save a few words. I think it also needs to keep its capitalization. If you're looking to change the string, I would focus on the word "temperature." Regular people think of "temperature" as something having to do with heat and cold, not colors. Only artists and computer experts generally understand that colors can have a temperature. |
kcms/nightcolor/package/contents/ui/main.qml | ||
---|---|---|
118 | There are some technical terms that should stay "technical," "color temperature" is one of those. |
kcms/nightcolor/package/contents/ui/main.qml | ||
---|---|---|
118 | I think using the technical term here is fine. IIRC f.lux tried to simplify this by adding a bunch of descriptors which compared a particular temperature value or even range to a lighting condition, e.g. one generated by incandescent bulbs. But I don't think we need this, users will figure it out. Regarding using uppercase c in "Night Color", that's 2 in favor and 2 against it. We had this dilemma with "Look and Feel" before and kept "Feel" capitalized because it's the name of a specific feature I guess. I'm not super passionate about what we choose, but I slightly lean towards leaving "Color" capitalized for now. That okay? |
kcms/nightcolor/package/contents/ui/main.qml | ||
---|---|---|
118 | This option talks about color temperature, so lower case makes sense. This is not a big deal, but just a little detail. |
The “Apply” button stops working after the “Times” mode is activated.
Before turning on this mode, the rest works fine.
To fix, you can delete the line “Mode=Times" from the file
~/.config/kwinrc and restart the session.