Add "user-others" icon
ClosedPublic
Actions

Authored by GB_2 on Jul 30 2019, 9:08 AM.

Details

Reviewers

ndavis
ngraham

Group Reviewers

VDG

Commits

R266:4c1c97eb9d9b: Add "user-others" icon

Summary

BUG: 407782

Needed to represent permissions for other users.

Test Plan

Search for user-others in Cuttlefish.

Repository

R266 Breeze Icons

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript

GB_2 requested review of this revision.Jul 30 2019, 9:08 AM

I'll review this when I'm back from my vacation. I don't have my laptop with me.

Visually, it looks good to me! Two questions about the implementation details though:

In D22822#505557, @ngraham wrote:

Can we name it user-others? No other icon starts with user.

Sure.

Do we really need the 24px version?

Well, the other user/group icons also have 24px versions, so why not :-)

Rename icon to user-others

GB_2 retitled this revision from Add "users-other" icon to Add "user-others" icon.Aug 2 2019, 12:12 PM

GB_2 edited the test plan for this revision. (Show Details)

This revision is now accepted and ready to land.Aug 2 2019, 2:49 PM

This revision was automatically updated to reflect the committed changes.

		Path
A	M	icons-dark/actions/16/user-others.svg (8 lines)
A	M	icons-dark/actions/22/user-others.svg (8 lines)
A	M	icons-dark/actions/24/user-others.svg (8 lines)
A	M	icons/actions/16/user-others.svg (8 lines)
A	M	icons/actions/22/user-others.svg (8 lines)
A	M	icons/actions/24/user-others.svg (8 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	62782	30e216e		Jul 30 2019, 9:08 AM	★	★
Diff 2	62966	30e216e	Rename icon to `user-others`	Aug 2 2019, 12:12 PM	★	★
Diff 3	62978	38975bb	R266:4c1c97eb9d9b51aefc7dd3e6772505b8c3fb5ac2	Aug 2 2019, 2:52 PM	★	★