Port KRunner to Plasma Components 3
Needs ReviewPublic

Authored by apol on Jul 29 2019, 11:14 PM.

Details

Reviewers
broulik
Group Reviewers
Plasma
Summary

Using the new, stable components. Biggest change is that now we don't
have a clear button and we need to add it by hand.

Test Plan

Been using it for a few days, forgot to send the patch

Diff Detail

Repository
R120 Plasma Workspace
Branch
arcpatch-D22817
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 14583
Build 14601: arc lint + arc unit
apol created this revision.Jul 29 2019, 11:14 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJul 29 2019, 11:14 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
apol requested review of this revision.Jul 29 2019, 11:14 PM

The padding on the left of the TextField looks off and what's up with that clear button?


No tooltip shows up for the configure and close buttons.

lookandfeel/contents/runcommand/RunCommand.qml
56

Why?

59–61

Why?

226

Why remove this? It breaks highlighting of history items.

broulik requested changes to this revision.Jul 30 2019, 6:49 AM
This revision now requires changes to proceed.Jul 30 2019, 6:49 AM
ognarb added a subscriber: ognarb.Jul 30 2019, 7:20 AM

To add the clear button, maybe you can use Kirigami.SearchField instead?

apol updated this revision to Diff 62809.Jul 30 2019, 6:25 PM

Have tooltips actually shown

apol updated this revision to Diff 62811.Jul 30 2019, 6:35 PM
apol marked an inline comment as done.

cleanups

apol added inline comments.Jul 30 2019, 6:35 PM
lookandfeel/contents/runcommand/RunCommand.qml
56

The button's height is by default really big and krunner then looks rather comical.
Here we're making sure it all stays as big as the text field after all.

226

PC3 has no moving hightlight delegate, it's the delegate that highlights itself.

To add the clear button, maybe you can use Kirigami.SearchField instead?

+1, IMO this makes more sense than manufacturing our own search field, especially since the current implementation results in a close button that has a toolbutton style hover effect, unlike other ones.

To add the clear button, maybe you can use Kirigami.SearchField instead?

Not sure if that can do Plasma styling?

lookandfeel/contents/runcommand/RunCommand.qml
56

Then this is a regression from PC2 and should be fixed.
There's even a manual test for PC2 to address this, so PC3 should have the same behavior.

226

But now you get two "highlights", one following the mouse, one following the keyboard.