| broulik | |
| davidedmundson |
| Plasma |
System Tray sends two "ContextMenu" events which breaks focus.
One is send on mouse pressed, second on mouse clicked. As a result
right click on the system tray icon causes focus to lock on the icon.
If later user clicks somewhere else event is send to the first icon.
BUG: 376277
BUG: 409768
FIXED-IN: 5.17.0
The best to test with Skype for Linux with SNI bridge.
To reproduce:
After fix:
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
This fixes 27b1030756002e91b60ba51483efe9c2c477d16e, which reverts b9af99140365c8c8cf4e3744af7e13b35c35fa18, but not fully.
Maybe the behavior must be split between PlasmoidItem and StatusNotifierItem. Ideally, all menus opened on press but that has shown to be problematic for XembedSniProxy
@apol SNI applications (including XembedSniProxy) are using StatusNotifierItem.qml, which already has onClick handled for right button. That why we had ContextMenu event's duplicated.
@broulik Yes, probably onPressed should be handled in PasmoidItem, not in the AbstractItem to avoid this kind of problems. I would personally opt for consistency, though. As far as I know GTK is showing context menu on mouse click, not pressed. The same is for MS Windows (this does not mean we must follow this or reimplement Windows, no). What is your opinion?
Yes, probably onPressed should be handled in PasmoidItem, not in the AbstractItem to avoid this kind of problems.
Indeed, that would be the best solution.
I would personally opt for consistency, though. As far as I know GTK is showing context menu on mouse click, not pressed. The same is for MS Windows (this does not mean we must follow this or reimplement Windows, no). What is your opinion?
Gimp, Firefox, Chrome, Gedit, etc, they open it on press here, and so does Qt and the rest of KDE software, so this must be consistent to here, regardless of what someone else does.
Should this be done together with this change? I shouldn't be hard, I can move onPressed to PlasmoidItem, which will simplify the fix also?
I would personally opt for consistency, though. As far as I know GTK is showing context menu on mouse click, not pressed. The same is for MS Windows (this does not mean we must follow this or reimplement Windows, no). What is your opinion?
Gimp, Firefox, Chrome, Gedit, etc, they open it on press here, and so does Qt and the rest of KDE software, so this must be consistent to here, regardless of what someone else does.
Oh, right! I focused on tray icons only... That makes perfect sense.
I simplified the patch. It moves handling of onPressed to PlasmoidItem. This way we can have context menu when mouse is pressed for plasmoids and on click for SNI.