Differential D22770

Rework shuffle handling
ClosedPublic
Actions

Authored by astippich on Jul 27 2019, 8:11 AM.

Details

Reviewers
ngraham
mgallien
Commits
R255:aa0cd61793b2: Rework shuffle handling
Summary

Remove deprecated usage of qrand().
Keep a list of the previous, current and next track
when in shuffle mode, to be used in a following patch.
Simplify calling skip and previousTracks

Depends on D22769

Test Plan

all tests pass

Diff Detail

Repository
R255 Elisa
Branch
rework_shuffle
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 15495
Build 15513: arc lint + arc unit
astippich requested review of this revision.Jul 27 2019, 8:11 AM
astippich created this revision.
astippich edited the summary of this revision. (Show Details)Jul 27 2019, 8:12 AM
astippich edited the test plan for this revision. (Show Details)
mgallien added a comment.Aug 18 2019, 8:20 PM

I am unable to get arc to properly download this review patch. I will be waiting for D22769 to land and a rebase. Sorry

src/mediaplaylist.cpp
1312

missing space

astippich updated this revision to Diff 64343.Aug 22 2019, 6:16 PM
  • add space
  • rebase
astippich added a comment.Aug 24 2019, 3:12 PM

this should now apply cleanly

mgallien accepted this revision.Aug 26 2019, 5:26 AM

Thanks

This revision is now accepted and ready to land.Aug 26 2019, 5:26 AM
Closed by commit R255:aa0cd61793b2: Rework shuffle handling (authored by astippich). · Explain WhyAug 26 2019, 4:38 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 64343

View Options

autotests/mediaplaylisttest.cpp

Loading...
View Options

src/mediaplaylist.h

Loading...
View Options

src/mediaplaylist.cpp

Loading...