Inspired by D22006
Details
- Reviewers
ngraham nicolasfella - Group Reviewers
Frameworks - Maniphest Tasks
- T8552: Polish Open/Save dialogs
- Commits
- R241:10b6d83bbc4c: [KDirOperator] Use more human-readable sort order descriptions
LANG=EN ctest
Diff Detail
- Repository
- R241 KIO
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Code looks sensible, haven't tried it yet
src/filewidgets/kdiroperator.cpp | ||
---|---|---|
1979 | Remove commented code |
src/filewidgets/kdiroperator.cpp | ||
---|---|---|
1979 | Thanks ;) |
I tried this out but I'm not actually seeing the menu items in the open/save dialogs change at all. :/
Have you tried with gwenview ?
For some reason, it does not work in kate but works in gwenview after installing kio, not event recompiling gwenview.
I have the same issue, I use the test app kfilewidgettest_saving_gui in kio tests dir for my tests usually.
I guess the old kio is kept in memory somewhere in kdeinit somewhere since kate uses it but not gwenview.
I have tried relaunching kdeinit5 but this does not seem to work.
Yes, it does work in Gwenview. How odd.
Anyway, not an issue with your patch, for sure. Patch LGTM!
src/filewidgets/kdiroperator.cpp | ||
---|---|---|
1992 | Why change this? kdiroperator should definitely be ported to use the new connect syntax, but it should be done all at once in its own patch, not one at a time. |
src/filewidgets/kdiroperator.cpp | ||
---|---|---|
1992 | _k_slotSortReversed parameter means whether or not the sorting is reversed. A closure was the simple course of action to implement this, and could be reused as is for the ascending action as well. |
Shouldn't it be "Newest First" instead of "Newest first", to be consistent with other menu items (i.e. "Folders First", etc.)?