Use more human-readable sort order descriptions
ClosedPublic

Authored by nicolasfella on Sat, Jun 22, 4:21 PM.

Details

Summary

Anecdotal evidence shows that ascending/descending regularly takes people longer to process than necessary. This patch implements more human-friendly sort order descriptions, in particular:

A-Z/Z-A for text
Newest first/oldest-first for time
Lowest first/highest first for rating
smallest first/largest first for sizes

If there is no string for a particular role defined it will fall back to Ascending/Descending.

I'm aware that not every language uses A-Z. In this case the translator can pick any string that represents the concept of text sorting

Test Plan

Sort view in various ways

Diff Detail

Repository
R318 Dolphin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
nicolasfella created this revision.Sat, Jun 22, 4:21 PM
Restricted Application added a project: Dolphin. · View Herald TranscriptSat, Jun 22, 4:21 PM
Restricted Application added a subscriber: kfm-devel. · View Herald Transcript
nicolasfella requested review of this revision.Sat, Jun 22, 4:21 PM
ngraham edited the summary of this revision. (Show Details)Sat, Jun 22, 4:30 PM

I love the better UI! However the code refactoring to use lambdas instead of a dedicated toggleSortOrder() function seems unrelated and could be done in another patch. Could you submit that separately? Thanks!

ngraham accepted this revision.Tue, Jun 25, 9:47 AM

Never mind, I was misreading the diff. Definitely related. LGTM, and this is a hugely awesome change!

This revision is now accepted and ready to land.Tue, Jun 25, 9:47 AM
This revision was automatically updated to reflect the committed changes.