bump Qt version to 5.11 and remove unrequired code
ClosedPublic
Actions

Authored by astippich on Jul 25 2019, 4:23 PM.

Details

Reviewers

ngraham
mgallien

Commits

R255:3a240602846f: bump Qt version to 5.11 and remove unrequired code

Summary

Bump the minimum Qt version to 5.11.
With D21943, Elisa will effictively depend on 5.11 anyways.
Additionally, Qt 5.10 is now untested by CI.
Bumping also allows to remove a local copy of the
model tester and gives a nice cleanup.

Diff Detail

Repository

R255 Elisa

Branch

bumpQt

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 14421
Build 14439: arc lint + arc unit

astippich requested review of this revision.Jul 25 2019, 4:23 PM

astippich created this revision.

Harbormaster completed remote builds in B14421: Diff 62553.Jul 25 2019, 4:23 PM

Given that we're already depending on something newer than the 5.9 Qt LTS version, I don't see the harm in this, especially if it allows us to clean some things up.

This revision is now accepted and ready to land.Jul 25 2019, 4:28 PM

Closed by commit R255:3a240602846f: bump Qt version to 5.11 and remove unrequired code (authored by astippich). · Explain WhyJul 25 2019, 4:33 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

		Path
M		CMakeLists.txt (2 lines)
D	M	LICENSE.GPL3-EXCEPT (704 lines)
M		autotests/CMakeLists.txt (4 lines)
M		autotests/alltracksproxymodeltest.cpp (2 lines)
M		autotests/datamodeltest.cpp (2 lines)
M		autotests/mediaplaylisttest.cpp (2 lines)
D	M	autotests/qabstractitemmodeltester.h (134 lines)
D	M	autotests/qabstractitemmodeltester.cpp (831 lines)
M		autotests/trackmetadatamodeltest.cpp (2 lines)