Differential D22742

Show about distro KCM in System Settings' System Administration category
ClosedPublic
Actions

Authored by ngraham on Jul 25 2019, 5:21 PM.

Details

Reviewers
filipf
GB_2
Group Reviewers
VDG
Plasma
Commits
R102:09598972736b: Show about distro KCM in System Settings' System Administration category
Summary

This is an alternative to D22728. It makes the System Information KCM appear in
System Settings' System Administration section.

Advantages over D22728:

  • The information is more discoverable
  • It automatically disappears if KInfoCenter is not installed or removed
  • It requires no changes to SystemSettings' fragile codebase

Disadvantages:

  • Since it doesn't open KInfoCenter or have a link to it, all the other information in KInfoCenter is not exposed
  • If we do later want to adjust this KCM to have a button to open KInfoCenter when pushed, we'll hit https://bugs.kde.org/show_bug.cgi?id=410169 since the KCM will be already open in System Settings

FEATURE: 409811
FIXED-IN: 5.17.0

Test Plan

Diff Detail

Repository
R102 KInfoCenter
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ngraham created this revision.Jul 25 2019, 5:21 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJul 25 2019, 5:21 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.Jul 25 2019, 5:21 PM
ngraham edited the summary of this revision. (Show Details)Jul 25 2019, 5:22 PM
filipf accepted this revision.Jul 26 2019, 1:03 PM
filipf added a subscriber: filipf.

+1 for the feature, with how everyone is used to phones nowadays, I think a fair share of users would expect to see this information in system settings.

I like this approach more than the other one primarily because of the reason no.1 you listed - it's more discoverable.

Tested it out as well and it works fine.

This revision is now accepted and ready to land.Jul 26 2019, 1:03 PM
ngraham added a comment.Jul 26 2019, 1:21 PM

Yeah I slightly prefer it as well, for just that reason.

mthw added a subscriber: mthw.Jul 26 2019, 6:27 PM
GB_2 accepted this revision as: GB_2.Aug 1 2019, 12:53 PM
Closed by commit R102:09598972736b: Show about distro KCM in System Settings' System Administration category (authored by ngraham). · Explain WhyAug 1 2019, 8:57 PM
This revision was automatically updated to reflect the committed changes.
• ghost34 added a subscriber: • ghost34.Aug 4 2019, 4:15 PM

Can add a GPU information in Hardware?

ngraham added a comment.Aug 4 2019, 5:01 PM

File a bug on KInfoCenter :)

Revision Contents
Changeset List

Diff 62940

View Options

Modules/about-distro/src/about-distro.desktop

Loading...