Remove phonon KCM
ClosedPublic

Authored by nicolasfella on Jul 21 2019, 4:41 PM.

Details

Summary

Most of the Phonon KCM settings have been moved to plasma-pa. The remaining settings server very specific use cases that are mostl likely not worth exposing them front and center.

@sitter said he has a version of the settings to be integtated into phonon so the remaining three users can still access them

See T9091

Test Plan

builds

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
nicolasfella created this revision.Jul 21 2019, 4:41 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJul 21 2019, 4:41 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
nicolasfella requested review of this revision.Jul 21 2019, 4:41 PM
nicolasfella edited the summary of this revision. (Show Details)Jul 21 2019, 4:42 PM
pino added a subscriber: pino.Jul 21 2019, 5:03 PM

Erm, so what if you do not use plasma-pa?

@sitter said he has a version of the settings to be integtated into phonon so the remaining three users can still access them

this

pino added a comment.Jul 21 2019, 6:50 PM

@sitter said he has a version of the settings to be integtated into phonon so the remaining three users can still access them

this

... doesn't say anything. Before removing stuff that works, it is a good idea to wait for the "potential replacement" to be implemented, tested, and confirmed usable as such.

@sitter can you post your patch with that?

Sweet, thanks!

sitter requested changes to this revision.Wed, Aug 28, 9:54 AM

Also needs removal of doc/kcontrol/phonon/ and also the qdebugcategory plasma-desktop.categories:org.kde.kcm.phonon kcm module phonon IDENTIFIER [KCM_PHONON_LOG]

This revision now requires changes to proceed.Wed, Aug 28, 9:54 AM
  • Remove unused stuff
Restricted Application added a project: Documentation. · View Herald TranscriptWed, Aug 28, 10:01 AM
Restricted Application added a subscriber: kde-doc-english. · View Herald Transcript
sitter accepted this revision.Wed, Aug 28, 10:03 AM

Good to land. Phonon 4.11 replaces this KCM with a new phononsettings application, which is a simple port of the KCM to a standalone application.

This revision is now accepted and ready to land.Wed, Aug 28, 10:03 AM
This revision was automatically updated to reflect the committed changes.
ngraham removed a subscriber: ngraham.Wed, Aug 28, 4:12 PM
ngraham added a subscriber: ngraham.

[spam comment removed by sysadmin]