sgoth (Sebastian Goth)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Tue, Mar 24, 2:00 PM (4 d, 11 h)
Availability
Available

Recent Activity

Wed, Mar 25

sgoth added a comment to D28281: Add options for OSD feedback.

I see. Then i'll let $things happen. Thanks!

Wed, Mar 25, 8:45 PM · Plasma
sgoth added a comment to D28281: Add options for OSD feedback.

Cool thanks!

Wed, Mar 25, 8:37 PM · Plasma
sgoth added a comment to D28281: Add options for OSD feedback.

Ah, that seems a lot better yes, thanks.

Wed, Mar 25, 8:26 PM · Plasma
sgoth updated the diff for D28281: Add options for OSD feedback.

Refactor show functions to be members of VolumeOsd

Wed, Mar 25, 8:25 PM · Plasma
sgoth added a comment to D28281: Add options for OSD feedback.

Yeah, was unsure too if it's a good idea but now with your sanitized wording i'd prefer it that way :)
But if i should go for a single OSD on/off i wouldn't mind either.

Wed, Mar 25, 8:01 PM · Plasma
sgoth added a comment to D28281: Add options for OSD feedback.

now with spacing

Wed, Mar 25, 7:56 PM · Plasma
sgoth updated the diff for D28281: Add options for OSD feedback.

Add spacing

Wed, Mar 25, 7:55 PM · Plasma
sgoth updated the diff for D28281: Add options for OSD feedback.

Change wording

Wed, Mar 25, 7:53 PM · Plasma
sgoth added a comment to D28281: Add options for OSD feedback.

"default output"
"Default output"
"Default output device" ?

Wed, Mar 25, 7:53 PM · Plasma
sgoth added a comment to D28281: Add options for OSD feedback.

Oh.. good catch thanks :)

Wed, Mar 25, 5:39 PM · Plasma
sgoth updated the diff for D28281: Add options for OSD feedback.

Fix typo

Wed, Mar 25, 5:36 PM · Plasma
sgoth added a comment to D28281: Add options for OSD feedback.

Not sure about the actual wording and whether we would want all 3 of them.
Probably would use "input volume", "output volume" but i tried to match the existing "aural feedback" string.

Wed, Mar 25, 2:54 PM · Plasma
sgoth requested review of D28281: Add options for OSD feedback.
Wed, Mar 25, 2:49 PM · Plasma

Tue, Mar 24

sgoth added a comment to D28242: Fix 'Audio Setup'.

If phononsettings is missing/uncallable the message box inf KMixWindow::forkExec is shown providing at least some feedback.
For the kcmshell5 call, KProcess::startDetached is able to start the process - but that fails internally. I don't see a way to fix that in this 'fire and forget' style besides validating kcm_pulseaudio is available.

Tue, Mar 24, 4:10 PM
sgoth added a comment to D28242: Fix 'Audio Setup'.

I'm aware that the proposed change is still far from optimal as the error handling doesn't work for missing kcm modules and still may result in silent errors for the user.
If you think rewriting that to verify the kcm actual exists is the way to go, please say so. I was reluctant to add the KF5Service dependency to enumerate kcms (at least i see kcmshell uses that).

Tue, Mar 24, 2:53 PM
sgoth requested review of D28242: Fix 'Audio Setup'.
Tue, Mar 24, 2:47 PM