Differential D22576

Mimic Kirigami InlineMessage for TrackImportNotification
ClosedPublic
Actions

Authored by astippich on Jul 20 2019, 7:51 AM.

Details

Reviewers
ngraham
mgallien
Commits
R255:6bf4271e847e: Mimic Kirigami InlineMessage for TrackImportNotification
Summary

Adjust the look of the track import notification to match
the one of the InlineMessage for consistency.

Diff Detail

Repository
R255 Elisa
Branch
visuals_import_notification
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 14154
Build 14172: arc lint + arc unit
astippich requested review of this revision.Jul 20 2019, 7:51 AM
astippich created this revision.
astippich added a comment.Jul 20 2019, 7:53 AM


We cannot use the InlineMessage directly due to the BusyIndicator

ngraham accepted this revision.Jul 20 2019, 1:47 PM

+1 for visual consistency. However I'm not a fan of emulating the look with a custom control here; it'll break the moment InlineMessage is changed to look like something else.

We can go with this for now, but I'd prefer for InlineMessage to gain the ability to display a busy indicator natively, and then we can port it to use that directly. Let's add a TODO comment in the code that mentions this.

This revision is now accepted and ready to land.Jul 20 2019, 1:47 PM
Closed by commit R255:6bf4271e847e: Mimic Kirigami InlineMessage for TrackImportNotification (authored by astippich). · Explain WhyJul 20 2019, 4:49 PM
This revision was automatically updated to reflect the committed changes.
astippich added a comment.Jul 20 2019, 4:51 PM
In D22576#498503, @ngraham wrote:

+1 for visual consistency. However I'm not a fan of emulating the look with a custom control here; it'll break the moment InlineMessage is changed to look like something else.

We can go with this for now, but I'd prefer for InlineMessage to gain the ability to display a busy indicator natively, and then we can port it to use that directly. Let's add a TODO comment in the code that mentions this.

I added the comment. I thought this might a somewhat special case to be integrated into Kirigami, but that is of course the best solution.
I don't know how well it integrates into the InlineMessage, but I can give it a try.

Revision Contents
Changeset List

PathPackages
Msrc/qml/TrackImportNotification.qml (35 lines)

Diff 62096

View Options

src/qml/TrackImportNotification.qml

Loading...