Add multiple datasets to number-in-order and even and odd activity
Status: WIP
timotheegiet | |
jjazeix |
Add multiple datasets to number-in-order and even and odd activity
Status: WIP
apply the changes on multiple dataset branch or pull changes from gsoc_akshaychd_number_in_order_multiple_datasets,
Lint Skipped |
Unit Tests Skipped |
Why did you duplicate the svg images from planegame in the alphabet-sequence activity (cloud, cloud_storm and tuxhelico) ?
It is not needed and only increase the size of the package.
@echarruau @timotheegiet
For me, there is no pedagogic usefulness to finding words in the good order in alphabetical_order: the child does not see all the words at start so it's just going on all the words expecting it's the first one to find (especially when showNext is false).
I think we should think on how to improve the pedagogic side of these activities instead of adding dataset (but not on the scope of this gsoc)...
src/activities/alphabet-sequence/ActivityConfig.qml | ||
---|---|---|
42 | not adapted | |
src/activities/numbers-odd-even/resource/1/Data.qml | ||
28 | up to | |
src/activities/planegame/resource/1/Data.qml | ||
2 | extra line |
Actually I agree with Johnny's comment about alphabet-sequence activity; better not add dataset to it and instead see how we can improve its pedagogical side.
Hi,
Not sure I agree with Johnny and Timothée.
I think there is as much interest in selecting the next word in alphabetical order that there is in selecting the next number. If you start with a word like "action" then present "zebra" then "boat" then "coat" then "three" then "dount", if your pupil is able to skip "zebra" and "three" then it is a nice activity.
We just need to make sure that we have two words on the screen before to allow the helicopter to move.
What we can do if we want to have an active pedagogical side is to make the activity interactive.
When the child makes a mistake we can tell him that the previous word was for example "action", that he sees that the following word is "zebra" but that "z" is after the "b" of "boat".
But this is not part of multipledataset gsoc :) It is more a full new task for after gsoc!
By the way, this would be great to be done with numbers too, this would allow us to give number series such as 1 5 8 10 45 and not just 1 2 3 4 5 6.
Emmanuel
Yes, there is an interest but the activity needs to be reworked for it. For now, you can have "zebra" then "boat" then "action" but when "boat" appears, you have no way to know if it is the first word of the sequence or not and you'll try anyway to select "boat". If it is the good word, then boat is first in the sequence but as you don't know all the words of the sequence, it's just "luck".
If you have the next word to select, it's just find the good word, the child may not bother with the alphabetical order.
I think we should focus more on ascending_order activity than these ones.
We just need to make sure that we have two words on the screen before to allow the helicopter to move.
What we can do if we want to have an active pedagogical side is to make the activity interactive.
When the child makes a mistake we can tell him that the previous word was for example "action", that he sees that the following word is "zebra" but that "z" is after the "b" of "boat".But this is not part of multipledataset gsoc :) It is more a full new task for after gsoc!
By the way, this would be great to be done with numbers too, this would allow us to give number series such as 1 5 8 10 45 and not just 1 2 3 4 5 6.
Emmanuel
I agree with you that ascending order is of a much higher priority and that this one needs to be reworked.
src/activities/alphabet-sequence/ActivityConfig.qml | ||
---|---|---|
48 | You can replace the loop with this simple condition: | |
src/activities/alphabet-sequence/resource/1/Data.qml | ||
31 ↗ | (On Diff #62886) | Please add translator comments. |
src/activities/numbers-odd-even/resource/1/Data.qml | ||
33 | Can you please add a comment telling what showNext does? Will make the code more readable for anyone who would read the code in the future. |
src/activities/alphabet-sequence/ActivityConfig.qml | ||
---|---|---|
48 | @amankumargupta But we cannot use the statement if we have to add another mode in the future. |
As per the discussion above, I have removed multiple datasets from alphabet_sequence activity and added logic to use simple dataset for alphabet sequence
Tested, for me it's good to merge.
I wait for other mentors advices on the code before pushing the "Accept Revision" button.
I have this warning when starting alphabet-sequence: qrc:/gcompris/src/activities/planegame/planegame.js:81: TypeError: Cannot read property 'bar' of undefined
Except this, it is good for me
src/activities/numbers-odd-even/resource/2/Data.qml | ||
---|---|---|
29 | //: is for translators comments, not for developers comments, you can drop the : | |
src/activities/planegame/Planegame.qml | ||
85 | string? |