Differential D22545

Add missing include QDate
ClosedPublic
Actions

Authored by usta on Jul 18 2019, 11:35 PM.

Details

Reviewers
Calligra-Devel-list
boemann
Group Reviewers
Calligra: 3.0
Summary

sheets/plugins/calendar/CalendarToolWidget.cpp is missing QDate header. Without this calligra couldnt compile

Diff Detail

Repository
R8 Calligra
Lint
Lint Skipped
Unit
Unit Tests Skipped
usta created this revision.Jul 18 2019, 11:35 PM
Restricted Application added a project: Calligra: 3.0. · View Herald TranscriptJul 18 2019, 11:35 PM
usta requested review of this revision.Jul 18 2019, 11:35 PM
boemann accepted this revision.Jul 19 2019, 10:08 AM
boemann added a subscriber: boemann.

btw For such small fixes we don't usually require review

This revision is now accepted and ready to land.Jul 19 2019, 10:08 AM
usta added a comment.Jul 19 2019, 10:10 PM

i will just commit this to master or do i need to xommit to a branch then merge it to master ? (i have been away from kde about more then 6 years)

pino added a subscriber: pino.Jul 20 2019, 3:25 AM
In D22545#498239, @usta wrote:

i will just commit this to master or do i need to xommit to a branch then merge it to master ?

Please commit to master, then cherry-pick to calligra/3.1 (too many differences, so do not try to merge).

usta added a subscriber: dfaure.Jul 24 2019, 2:40 AM

Because i was away for a short vacation i coudnt commit this one but
@dfaure committed same thing :) with 0c5430697bdcf41a45046107b28014e40c49a11a
So i think we need to discard this review

danders closed this revision.Mar 13 2020, 9:01 AM

Revision Contents
Changeset List

Diff 62016

View Options

sheets/plugins/calendar/CalendarToolWidget.cpp

Loading...