[LNF KCM] make it possible to close the preview

Authored by ngraham on Jul 18 2019, 8:47 PM.



The preview window doesn't respond to setting its visibility to false, so currently
it can't actually be closed without using the task manager or another external way
of closing windows.

Fix the issue by triggering the window's close() function instead.

Test Plan

Preview a theme and click on the close button, or anywhere else, or hit the Esc key

Diff Detail

R119 Plasma Desktop
make-lnf-preview-escapeable (branched from Plasma/5.16)
No Linters Available
No Unit Test Coverage
Build Status
Buildable 14109
Build 14127: arc lint + arc unit
ngraham created this revision.Jul 18 2019, 8:47 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJul 18 2019, 8:47 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.Jul 18 2019, 8:47 PM

I'm confused. I can press Alt+F4 or just click the window or the close button just fine.

Alt-F4 works of course, but for me, without this patch none of the other methods of closing it work. Could it be a Qt regression? I notice that this patch is required on my Qt 5.13 machine, but in my Qt 5.12.3-using VM, the existing code works without this patch.

ognarb added a subscriber: ognarb.Jul 18 2019, 9:39 PM

I had the same problem today with qt 5.13.0, framework 5.59 and plasma 5.16.3. I switched to a tty to close system settings :/.

davidedmundson accepted this revision.Jul 19 2019, 9:50 AM
This revision is now accepted and ready to land.Jul 19 2019, 9:50 AM
This revision was automatically updated to reflect the committed changes.