Differential D22542

Port from KPassivePopup to KNotification
ClosedPublic
Actions

Authored by nicolasfella on Jul 18 2019, 8:21 PM.

Details

Reviewers
sboehmann
dakon
broulik
fb
dfaure
davidedmundson
Commits
R360:8f96293a42d6: Port from KPassivePopup to KNotification
Summary

KPassivePopup is hideous and shouldn't be used any more. Replace it with a persistent KNotification

Test Plan

Click on tray icon: Notification appears. Start a tea: Notification changes content. Click tray again, notification disappears

Diff Detail

Repository
R360 KTeaTime
Branch
noti
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 14108
Build 14126: arc lint + arc unit
nicolasfella created this revision.Jul 18 2019, 8:21 PM
Restricted Application added a subscriber: kde-utils-devel. · View Herald TranscriptJul 18 2019, 8:21 PM
nicolasfella requested review of this revision.Jul 18 2019, 8:21 PM
davidedmundson accepted this revision.Jul 21 2019, 8:50 AM
This revision is now accepted and ready to land.Jul 21 2019, 8:50 AM
Closed by commit R360:8f96293a42d6: Port from KPassivePopup to KNotification (authored by nicolasfella). · Explain WhyJul 21 2019, 8:52 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/kteatime.notifyrc (5 lines)
Msrc/toplevel.h (5 lines)
Msrc/toplevel.cpp (32 lines)

Diff 62009

View Options

src/kteatime.notifyrc

Loading...
View Options

src/toplevel.h

Loading...
View Options

src/toplevel.cpp

Loading...