fix the compilation album insertion
ClosedPublic
Actions

Authored by mgallien on Jul 16 2019, 10:05 PM.

Details

Reviewers

ngraham
astippich

Group Reviewers

Elisa

Commits

R255:61f063362cde: fix the compilation album insertion

Summary

partial fix for handling albums without album artist

partially handle the case of compilations not getting Various Artists as
album artist

BUG: 409147

Test Plan

all tests are fine and most common cases should be covered.

Diff Detail

Repository

R255 Elisa

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

mgallien requested review of this revision.Jul 16 2019, 10:05 PM

mgallien created this revision.

Harbormaster completed remote builds in B14023: Diff 61878.Jul 16 2019, 10:05 PM

Fixes the bug for me:

However it introduces a new bug that many of my albums now show the artist for every song, even when they're all the same:

Also needed to manually refresh my music collection. That didn't happen automatically.

more fixes for album discovery when album artist may be missing

fixes all automated tests and partially fixing review comments

Harbormaster completed remote builds in B14557: Diff 62768.Jul 29 2019, 9:18 PM

It now shows duplicated artists in the albums view here

more fixes for album discovery when album artist may be missing
correctly get the single common artists for albums without album artist

albums from a single artist and no album artist are now working correctly

Harbormaster completed remote builds in B14811: Diff 63217.Aug 6 2019, 4:52 PM

In D22499#506161, @astippich wrote:

It now shows duplicated artists in the albums view here

Thanks for the tests.
Please let me know if you notice other issues ?

mgallien retitled this revision from [WIP] partially fix the compilation album insertion to fix the compilation album insertion.Aug 6 2019, 4:57 PM

mgallien edited the test plan for this revision. (Show Details)

This fixes the issue fully for me and I cannot find any regressions--after a full re-index. That did not happen automatically; maybe it should? Can it?

This revision is now accepted and ready to land.Aug 6 2019, 6:37 PM

Closed by commit R255:61f063362cde: fix the compilation album insertion (authored by mgallien). · Explain WhyAug 6 2019, 8:10 PM

This revision was automatically updated to reflect the committed changes.

In D22499#507680, @ngraham wrote:

This fixes the issue fully for me and I cannot find any regressions--after a full re-index. That did not happen automatically; maybe it should? Can it?

It cannot yet do it. We would need a way to tell the user:

We can fix/improve the data about your music but doing so can take some time. Can Elisa do it now ? [yes] [no]

Ideally, it would keep using the old data until full reindex is done.

The artists view is not working properly now with a fresh database. The artists are correctly shown. But when clicking on them no albums show up

In D22499#508610, @astippich wrote:

The artists view is not working properly now with a fresh database. The artists are correctly shown. But when clicking on them no albums show up

Sorry, I will check with the flatpak build. Could you open a bug report about that ?

mgallien mentioned this in D23053: Fix fetching all albums from an artist even without album artist tag.Aug 9 2019, 4:50 PM

mgallien mentioned this in R255:c07cbe45eecf: Fix fetching all albums from an artist even without album artist tag.Aug 9 2019, 9:56 PM

Revision Contents
Changeset List

			Path	Packages
M			autotests/databaseinterfacetest.cpp (182 lines)
M			autotests/datamodeltest.cpp (23 lines)
M			autotests/mediaplaylisttest.cpp (14 lines)
M			src/databaseinterface.h (7 lines)
M			src/databaseinterface.cpp (522 lines)
M			src/mediaplaylist.h (1 line)
M			src/models/trackmetadatamodel.cpp (2 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	61878	8b485e0		Jul 16 2019, 10:05 PM	★	★
Diff 2	62768	463508b	- more fixes for album discovery when album artist may be missing	Jul 29 2019, 9:18 PM	★	★
Diff 3	63217	40f5d8e	- more fixes for album discovery when album artist may be missing	Aug 6 2019, 4:52 PM	★	★
Diff 4	63229	c6e8f3e	R255:61f063362cde8dd26f36cc5ce35740f54702bcdf	Aug 6 2019, 8:09 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
775e5f205141	6574089de743	a4de39ed1f10	Matthieu Gallien	correctly get the single common artists for albums without album artist	Aug 4 2019, 2:10 PM
a4de39ed1f10	bd49f2888f62	fcb38fc5326e	Matthieu Gallien	more fixes for album discovery when album artist may be missing	Jul 29 2019, 9:13 PM
fcb38fc5326e	5b36943bd650	f47fc93ba677	Matthieu Gallien	[WIP] partially fix the compilation album insertion (Show More…)	Jul 16 2019, 9:59 PM
f47fc93ba677	f2fec9df4b91	40f5d8e31c20	Matthieu Gallien	partially fix the compilation album insertion	Jul 13 2019, 8:59 AM