Removes a bunch of boilerplate CMake code and allows kpackage to do
some smart things, e.g. drops our runtime dependency on the
DesktopFileParser and we get to just use json directly.
Details
- Reviewers
zzag - Group Reviewers
KWin - Commits
- R108:6cd9b2ba256a: Install KPackages with kpackage_install_package
Ran kwin, now it doesn't use the desktop to json translation path, everything still works.
Diff Detail
- Repository
- R108 KWin
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Is it possible to use kpackage_install_package inside of each effect's CMakeLists.txt file? The problem is that now "toplevel" effect directories contain only one directory - package. We should either keep CMakeLists.txt or flatten everything out (I'd prefer the former).
Is it possible to use kpackage_install_package inside of each effect's CMakeLists.txt file? The problem is that now "toplevel" effect directories contain only one directory - package.
how is having only one directory and one CMakeLists.txt better?
I don't think that's a good idea. Then you're hiding the call for no reason.
We could consider moving all packages up, but that's also something that could have been done earlier and nobody did the change. It can be revisited in a different patch.
It can be revisited in a different patch.
Why can't it be done in this patch?
but that's also something that could have been done earlier and nobody did the change
I assume that we followed common kpackage file structure.
Because my goal is to fix how things are installed not to reorganise the repository.
but that's also something that could have been done earlier and nobody did the change
I assume that we followed common kpackage file structure.
No, we didn't.
You have to copy scripted effects to the build directory because CI doesn't do make install.