Is it possible to use kpackage_install_package inside of each effect's CMakeLists.txt file? The problem is that now "toplevel" effect directories contain only one directory - package. We should either keep CMakeLists.txt or flatten everything out (I'd prefer the former).

Is it possible to use kpackage_install_package inside of each effect's CMakeLists.txt file? The problem is that now "toplevel" effect directories contain only one directory - package.

how is having only one directory and one CMakeLists.txt better?

In D22474#495862, @davidedmundson wrote:

how is having only one directory and one CMakeLists.txt better?

This will be a good example of how to structure third party scripted effects.

In D22474#495857, @zzag wrote:

Is it possible to use kpackage_install_package inside of each effect's CMakeLists.txt file? The problem is that now "toplevel" effect directories contain only one directory - package. We should either keep CMakeLists.txt or flatten everything out (I'd prefer the former).

I don't think that's a good idea. Then you're hiding the call for no reason.

We could consider moving all packages up, but that's also something that could have been done earlier and nobody did the change. It can be revisited in a different patch.

Ping?

It can be revisited in a different patch.

Why can't it be done in this patch?

but that's also something that could have been done earlier and nobody did the change

I assume that we followed common kpackage file structure.

In D22474#496273, @zzag wrote:

It can be revisited in a different patch.

Why can't it be done in this patch?

Because my goal is to fix how things are installed not to reorganise the repository.

but that's also something that could have been done earlier and nobody did the change

I assume that we followed common kpackage file structure.

No, we didn't.

You have to copy scripted effects to the build directory because CI doesn't do make install.