Differential D22490

Copy the packages into the build directory so they can be found without installign
ClosedPublic
Actions

Authored by apol on Jul 16 2019, 3:06 PM.

Details

Reviewers
zzag
Group Reviewers
KWin
Commits
R108:d3253257f960: Copy the packages into the build directory so they can be found without…
Summary

Fixes the execution of tests when not installed

Test Plan

Removed the installed effect and testTranslucency

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
apol created this revision.Jul 16 2019, 3:06 PM
Restricted Application added a project: KWin. · View Herald TranscriptJul 16 2019, 3:06 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
apol requested review of this revision.Jul 16 2019, 3:06 PM
zzag added a subscriber: zzag.Jul 16 2019, 3:11 PM
zzag added inline comments.
effects/CMakeLists.txt
134–154

install_effect is a pretty generic name, it can be applied to builtin effects too.

add/install_scripted_effect is a better name.

apol marked an inline comment as done.Jul 16 2019, 3:23 PM
apol updated this revision to Diff 61864.Jul 16 2019, 3:23 PM

address zzag's comment

zzag accepted this revision.Jul 16 2019, 3:26 PM

Thank you for the quick fix.

This revision is now accepted and ready to land.Jul 16 2019, 3:26 PM
Closed by commit R108:d3253257f960: Copy the packages into the build directory so they can be found without… (authored by apol). · Explain WhyJul 16 2019, 3:31 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Meffects/CMakeLists.txt (36 lines)

Diff 61865

View Options

effects/CMakeLists.txt

Loading...