Differential D22265

KPluginMetaData: use Q_DECLARE_METATYPE
ClosedPublic
Actions

Authored by apol on Jul 4 2019, 1:02 PM.

Details

Reviewers
mart
Group Reviewers
Frameworks
Commits
R244:318b0e752429: KPluginMetaData: use Q_DECLARE_METATYPE
Summary

This way it can be used with QVariant.

Diff Detail

Repository
R244 KCoreAddons
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
apol created this revision.Jul 4 2019, 1:02 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptJul 4 2019, 1:02 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
apol requested review of this revision.Jul 4 2019, 1:02 PM
mart accepted this revision.Jul 4 2019, 1:43 PM
This revision is now accepted and ready to land.Jul 4 2019, 1:43 PM
Closed by commit R244:318b0e752429: KPluginMetaData: use Q_DECLARE_METATYPE (authored by apol). · Explain WhyJul 4 2019, 3:58 PM
This revision was automatically updated to reflect the committed changes.
kossebau added a subscriber: kossebau.Jul 5 2019, 10:38 AM

This runs the chance to break some 3rd-party software which also calls the Q_DECLARE_METATYPE(KPluginMetaData) macro.
Any chance this could be moved to the place that needs this for now, and perhaps add a KF6 TODO instead?

See e.g. R36:3aacbbaab50ac6e0557c5d69c430459eb3d71ad7 which was needed to unbreak ark builds.

elvisangelaccio added a subscriber: elvisangelaccio.Jul 17 2019, 8:25 PM
In D22265#491249, @kossebau wrote:

This runs the chance to break some 3rd-party software which also calls the Q_DECLARE_METATYPE(KPluginMetaData) macro.
Any chance this could be moved to the place that needs this for now, and perhaps add a KF6 TODO instead?

See e.g. R36:3aacbbaab50ac6e0557c5d69c430459eb3d71ad7 which was needed to unbreak ark builds.

Ping?

Revision Contents
Changeset List

PathPackages
Msrc/lib/plugin/kpluginmetadata.h (3 lines)

Diff 61151

View Options

src/lib/plugin/kpluginmetadata.h

Loading...