So far we've been copying protocol specifications from wayland-protocols
repo to kwayland repo. The main issue with copying is that we have to
keep xml files in sync manually. A better approach would be to use xml
specs straight from wayland-protocols package.
Details
Details
- Reviewers
romangg davidedmundson - Group Reviewers
KWin Frameworks - Commits
- R127:40b86f7792eb: Use wayland-protocols
Compiles.
Diff Detail
Diff Detail
- Repository
- R127 KWayland
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
Why was it done differently until now?
I can't give you an answer, but my guess is for historical reasons. Initially, kwayland repo had only proprietary protocols, like server_decoration, etc. Protocols from wayland-protocols were copied to follow the pattern. Also perhaps because some protocols weren't in the current wayland-protocols release yet.
Comment Actions
Generally, I see nothing wrong with waiting until protocol foo becomes part of the current wayland-protocols release. If the protocol is really importatnt, we can make temporary copy and after several kwayland releases drop it.
Comment Actions
Also, it's worth to point out that neither weston, nor Mutter, nor wlroots copy protocol specs, they just have wayland-protocols as a dependency.
Comment Actions
Yea, let's wait until 5.60 branched and then push for 5.61 (after next weekend) as long as @davidedmundson does not say anything against it until then.
Comment Actions
It's the technically correct thing to do.
Generally, I see nothing wrong with waiting until protocol foo becomes part of the current wayland-protocols release.
The problem there is that then we're not giving proper feedback until after a release, and then it's too late.
But as you say, we can always copy them.