Differential D22047

Fix translation of actiondisplay
ClosedPublic
Actions

Authored by nicolasfella on Jun 23 2019, 2:43 PM.

Details

Reviewers

apol
aacid

Commits

R495:1405e495ccab: Fix translation of actiondisplay

Summary

To be able to be translated the entries need to be subentry of KPlugin

Diff Detail

Repository

R495 Purpose Library

Branch

unfuckup

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 13226
Build 13244: arc lint + arc unit

nicolasfella created this revision.Jun 23 2019, 2:43 PM

Restricted Application added a project: Frameworks. · View Herald TranscriptJun 23 2019, 2:43 PM

Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript

nicolasfella requested review of this revision.Jun 23 2019, 2:43 PM

Harbormaster completed remote builds in B13226: Diff 60498.Jun 23 2019, 2:43 PM

I do not see how this is supposed to fix the translations. Nothing translates the strings statically (like the various Name/Comment/etc), nor at runtime.

@aacid and I have been working on making it possible to translate arbitrary JSON entries. See https://phabricator.kde.org/R883:1544734

okay

This revision is now accepted and ready to land.Jun 23 2019, 3:06 PM

Closed by commit R495:1405e495ccab: Fix translation of actiondisplay (authored by nicolasfella). · Explain WhyJun 23 2019, 3:32 PM

This revision was automatically updated to reflect the committed changes.

aspotashev added a subscriber: aspotashev.Jun 30 2019, 11:32 AM

aspotashev added inline comments.

src/plugins/pastebin/pastebinplugin.json
105	oops, ActionDisplay should have ellipsis, e.g. "Pastebin..."

aspotashev added inline comments.Jun 30 2019, 11:34 AM

src/plugins/imgur/imgurplugin.json
105	same for Imgur :(

Revision Contents
Changeset List

			Path	Packages
M			src/alternativesmodel.cpp (2 lines)
M			src/plugins/bluetooth/bluetoothplugin.json (4 lines)
M			src/plugins/email/emailplugin.json (4 lines)
M			src/plugins/imgur/imgurplugin.json (4 lines)
M			src/plugins/kdeconnect/kdeconnectplugin.json (4 lines)
M			src/plugins/kdeconnect_sms/kdeconnectsmsplugin.json (4 lines)
M			src/plugins/ktp-sendfile/ktpsendfileplugin.json (4 lines)
M			src/plugins/nextcloud/nextcloudplugin.json (4 lines)
M			src/plugins/pastebin/pastebinplugin.json (4 lines)
M			src/plugins/phabricator/phabricatorplugin.json (4 lines)
M			src/plugins/reviewboard/reviewboardplugin.json (4 lines)
M			src/plugins/saveas/saveasplugin.json (4 lines)
M			src/plugins/telegram/telegramplugin.json (4 lines)
M			src/plugins/twitter/metadata.json (4 lines)
M			src/plugins/youtube/youtubeplugin.json (4 lines)