Differential D22026

Use own eventIds and ComponentName instead of generic plasma workspace ones
ClosedPublic
Actions

Authored by bruns on Jun 23 2019, 10:39 AM.

Details

Reviewers
jgrulich
lukas
ngraham
fvogt
Commits
R623:7268a2da05f8: Use own eventIds and ComponentName instead of generic plasma workspace ones
Summary

Currently, the notifications from the update applet use the standard
events from plasma workspace, which poses a number of problems:

  • the notifications can not be configured
  • the notifications are shown as originating from plasma workspace
  • grouping does not work properly (update notifications are mixed with others from PWS)
  • the notifications are filled with non-informative elements

Depends on D21973

Diff Detail

Repository
R623 Plasma PackageKit Updater
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
bruns requested review of this revision.Jun 23 2019, 10:39 AM
bruns created this revision.
bruns added a comment.Jun 23 2019, 10:41 AM

Old and new popup

ngraham accepted this revision.Jun 23 2019, 11:08 AM

I don't use this software, but LGTM in principle, visually, and code-wise.

This revision is now accepted and ready to land.Jun 23 2019, 11:08 AM
Closed by commit R623:7268a2da05f8: Use own eventIds and ComponentName instead of generic plasma workspace ones (authored by bruns). · Explain WhyJun 23 2019, 9:41 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 60543

View Options

src/declarative/CMakeLists.txt

Loading...
View Options

src/declarative/pkupdates.cpp

Loading...
View Options

src/declarative/plasma_pk_updates.notifyrc

Loading...