Make the notifications less obtrusive
ClosedPublic

Authored by bruns on Jun 23 2019, 10:43 AM.

Details

Summary

Currently, whenever the PK package cache is refreshed, a new notification
is show, even when the update count does not change. The notification
also persists after the update has installed.

To make the notifications less obtrusive:

  1. Skip the "You have N new updates" message generation completely when the update count is unchanged.
  2. In case the update count changes, close the old one generate a new one. Using "CloseOnTimeout" has the
  3. Change the "Updates Installed" notification from "Persistent" to "CloseOnTimeout". The notification is still in the history.
  4. After update installation, also remove the "You have N new updates" Popup.

Depends on D22026

Test Plan

call pkcon refresh multiple times

Diff Detail

Repository
R623 Plasma PackageKit Updater
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
bruns requested review of this revision.Jun 23 2019, 10:43 AM
bruns created this revision.

Old an new applet running in parallel, after multiple refreshes and after installing some updates:

  • old applet repeats same message
  • old popup persists although it no longer applies

If the update count changes to 0 for whatever reason, the existing notification isn't closed AFAICT.

bruns updated this revision to Diff 60525.Jun 23 2019, 5:13 PM

Close update count notification when all updates were installed without involving PK

fvogt accepted this revision.Jun 23 2019, 5:17 PM
This revision is now accepted and ready to land.Jun 23 2019, 5:17 PM
ngraham accepted this revision.Jun 23 2019, 5:47 PM
This revision was automatically updated to reflect the committed changes.