Change initial size of the config dialog
ClosedPublic

Authored by nicolasfella on Sat, Jun 22, 10:38 AM.

Details

Summary

The dialog is larger than it needs to be. Make it smaller

Diff Detail

Repository
R495 Purpose Library
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
nicolasfella created this revision.Sat, Jun 22, 10:38 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptSat, Jun 22, 10:38 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
nicolasfella requested review of this revision.Sat, Jun 22, 10:38 AM
nicolasfella edited the summary of this revision. (Show Details)Sat, Jun 22, 10:40 AM
aacid added a subscriber: aacid.Sat, Jun 22, 11:04 AM

How hard is to make the size be related to the contents instead of a magic number?

How hard is to make the size be related to the contents instead of a magic number?

+1, this would probably involve basing the size on the StackView's child items and bubbling that up to the top, rather than setting a hardcoded size at the top and making all the child items do anchors.fill: parent

If that's ridiculously difficult due to other bugs though, this is a reasonable improvement as-is.

ngraham accepted this revision.Sun, Jun 23, 9:17 PM

I looked into what it would take to make the size adjust to its contents and I don't think it's worth the effort here due to the way this dialog is constructed. Porting to use a real QtQuick dialog would solve a lot of problems, but until we do that, this change is fine.

This revision is now accepted and ready to land.Sun, Jun 23, 9:17 PM
nicolasfella retitled this revision from RFC: Change initial size of the config dialog to Change initial size of the config dialog.Mon, Jun 24, 4:09 PM
This revision was automatically updated to reflect the committed changes.