Add new Konqi avatars & remove classic, bluestyle, old konqi avatars
ClosedPublic

Authored by ndavis on Jun 20 2019, 4:39 PM.

Details

Summary

The Konqi mascots are so good, we might as well use them. Our existing avatars are not so good, so I'm removing them.

Test Plan

  1. Copy images to /usr/share/user-manager/avatars/konqui/
  2. Select a Konqi user icon from the gallery in the user_manager KCM.

Diff Detail

Repository
R128 User Manager
Branch
user-pictures (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 13044
Build 13062: arc lint + arc unit
ndavis created this revision.Jun 20 2019, 4:39 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJun 20 2019, 4:39 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ndavis requested review of this revision.Jun 20 2019, 4:39 PM
ndavis edited the test plan for this revision. (Show Details)Jun 20 2019, 4:44 PM
ndavis edited the test plan for this revision. (Show Details)

Very nice! What happens to a user who was using one of the old images though? Is it preserved, or does their user avatar suddenly become blank?

GB_2 added a subscriber: GB_2.Jun 20 2019, 4:57 PM

Great! I'd only change the name of these avatars:
Boss Konqi -> Banker Konqi
Hacker Konqi -> Developer Konqi / Programmer Konqi

I don't think Konqi should be called a banker when wearing a suit. It doesn't fit the collaborative non-profit nature of KDE. I think Boss Konqi is alright. Business Konqi can work too.

ndavis updated this revision to Diff 60163.Jun 20 2019, 5:41 PM
ndavis removed a subscriber: felixernst.

Change names of Bugcatcher and Officeworker to be more grammatically correct

ndavis edited the test plan for this revision. (Show Details)Jun 20 2019, 5:42 PM
ndavis updated this revision to Diff 60164.Jun 20 2019, 5:43 PM

Fix spelling of dualist

Hmm, I don't think "duelist" is the right word. That one makes me think "card shark".

Saying i

Hmm, I don't think "duelist" is the right word. That one makes me think "card shark".

Yeah, it was just a dumb Yu-Gi-Oh reference that doesn't really make sense in context.

ndavis updated this revision to Diff 60165.Jun 20 2019, 5:49 PM

Rename duelist to card shark

In D21939#482800, @GB_2 wrote:

Great! I'd only change the name of these avatars:
Boss Konqi -> Banker Konqi
Hacker Konqi -> Developer Konqi / Programmer Konqi

I chose boss and hacker because I want the names to be things that people want to identify as and I'm using the traditional definition of hacker.

ngraham accepted this revision.Jun 20 2019, 10:05 PM

I might prefer "Business Konqi", but "Boss" is probably fine.

Let's make sure to add some new avatars too, or else most of what we have will be Konqis. :) Also we need to make the avatar selection window a little bit wider by default so it shows three columns rather than two.

This revision is now accepted and ready to land.Jun 20 2019, 10:05 PM
filipf accepted this revision.Jun 20 2019, 10:06 PM
filipf added a subscriber: filipf.

Agreed with all the removals.

New ones should be sufficient for just about any screen and they look great. I'm okay with the namings. Good work!

If it's doable, I would only possibly consider replacing PC Builder Konqi with Guitar Player Konqi. It's might not be super clear what's happening in the former, but that latter is pretty obvious.

Agreed with all the removals.

New ones should be sufficient for just about any screen and they look great. I'm okay with the namings. Good work!

If it's doable, I would only possibly consider replacing PC Builder Konqi with Guitar Player Konqi. It's might not be super clear what's happening in the former, but that latter is pretty obvious.

Actually, I meant to include the guitar konqi. Not sure why it isn't there, but I'll blame it on Imagemagick being confusing to work with.

ndavis added a comment.EditedJun 21 2019, 5:40 AM

I feel like these names should be localized, but the gallery gets the names from the file names. No translations unless that gets fixed.

ndavis updated this revision to Diff 60185.Jun 21 2019, 8:48 AM

Add Musician Konqi

ndavis edited the test plan for this revision. (Show Details)Jun 21 2019, 8:50 AM
ngraham accepted this revision.Jun 21 2019, 8:53 AM
filipf accepted this revision.Jun 21 2019, 8:53 AM
This revision was automatically updated to reflect the committed changes.