The Konqi mascots are so good, we might as well use them. Our existing avatars are not so good, so I'm removing them.
Details
- Reviewers
ngraham filipf - Group Reviewers
VDG Plasma - Maniphest Tasks
- T9910: Revisit user avatar gallery images
- Commits
- R128:8be2414e1012: Add new Konqi avatars & remove classic, bluestyle, old konqi avatars
- Copy images to /usr/share/user-manager/avatars/konqui/
- Select a Konqi user icon from the gallery in the user_manager KCM.
Diff Detail
- Repository
- R128 User Manager
- Branch
- user-pictures (branched from master)
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 13042 Build 13060: arc lint + arc unit
Very nice! What happens to a user who was using one of the old images though? Is it preserved, or does their user avatar suddenly become blank?
Great! I'd only change the name of these avatars:
Boss Konqi -> Banker Konqi
Hacker Konqi -> Developer Konqi / Programmer Konqi
I don't think Konqi should be called a banker when wearing a suit. It doesn't fit the collaborative non-profit nature of KDE. I think Boss Konqi is alright. Business Konqi can work too.
Hmm, I don't think "duelist" is the right word. That one makes me think "card shark".
Saying i
Yeah, it was just a dumb Yu-Gi-Oh reference that doesn't really make sense in context.
I chose boss and hacker because I want the names to be things that people want to identify as and I'm using the traditional definition of hacker.
I might prefer "Business Konqi", but "Boss" is probably fine.
Let's make sure to add some new avatars too, or else most of what we have will be Konqis. :) Also we need to make the avatar selection window a little bit wider by default so it shows three columns rather than two.
Agreed with all the removals.
New ones should be sufficient for just about any screen and they look great. I'm okay with the namings. Good work!
If it's doable, I would only possibly consider replacing PC Builder Konqi with Guitar Player Konqi. It's might not be super clear what's happening in the former, but that latter is pretty obvious.
Actually, I meant to include the guitar konqi. Not sure why it isn't there, but I'll blame it on Imagemagick being confusing to work with.
I feel like these names should be localized, but the gallery gets the names from the file names. No translations unless that gets fixed.