Diffusion KIO 59b944470470

KDirOperator: Use a fixed line height for scroll speed

Authored by ahiemstra on Dec 21 2019, 6:55 PM.

Description

KDirOperator: Use a fixed line height for scroll speed

Summary:
This patch intends to do mostly the same as D19190, but for KDirOperator.
This uses the font's line height multiplied by the amount of scroll lines
from QApplication as a scroll speed for views. This makes the scroll speed
not depend on the icon size, which greatly improves scrolling behaviour.
For more details, see the linked review.

Test Plan:
Run tests/kfilewidgettest_gui and go to a directory with a lot of items.
Scroll around, then change icon size and see that scrolling speed remains
the same.

Reviewers: ngraham, elvisangelaccio

Reviewed By: ngraham, elvisangelaccio

Subscribers: ngraham, kde-frameworks-devel

Tags: Frameworks

Differential Revision: https://phabricator.kde.org/D25683

Details

Committed
ngrahamDec 21 2019, 6:56 PM
Reviewer
ngraham
Differential Revision
D25683: KDirOperator: Use a fixed line height for scroll speed
Parents
R241:9c131b294433: Qt 5.12 is now required so remove the ifdefs
Branches
Unknown
Tags
Unknown