Differential D21573

Scroll when pressing PageUp/PageDown
ClosedPublic
Actions

Authored by trmdi on Jun 4 2019, 8:59 AM.

Details

Reviewers
Zren
cfeck
elvisangelaccio
Group Reviewers
Dolphin
Commits
R318:038565b62f6c: Scroll when pressing PageUp/PageDown
Summary

Add PageUp/PageDown to the navigationPressed variable.
Remove the m_view->firstVisibleIndex() and m_view->lastVisibleIndex() tests because sometimes it does not work correctly.

BUG: 407118

Test Plan

Press PageUp/PageDOwn: it scrolls
Press Up/DOwn: it always scrolls

Diff Detail

Repository
R318 Dolphin
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 12388
Build 12406: arc lint + arc unit
trmdi created this revision.Jun 4 2019, 8:59 AM
Restricted Application added a project: Dolphin. · View Herald TranscriptJun 4 2019, 8:59 AM
Restricted Application added a subscriber: kfm-devel. · View Herald Transcript
trmdi requested review of this revision.Jun 4 2019, 8:59 AM
Zren added a comment.Jun 4 2019, 5:39 PM

Patch fixed the issue for me.

elvisangelaccio accepted this revision.Jun 4 2019, 7:47 PM
elvisangelaccio added a subscriber: elvisangelaccio.

Thanks for the quick fix :)

This revision is now accepted and ready to land.Jun 4 2019, 7:47 PM
Closed by commit R318:038565b62f6c: Scroll when pressing PageUp/PageDown (authored by trmdi). · Explain WhyJun 5 2019, 9:41 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 59119

View Options

src/kitemviews/kitemlistcontroller.cpp

Loading...