We used to append them, but that didn't work well and was crashing plasmashell
on fresh start.
A default desktop would be created alongside with the one provided by the
layout instead of replacing it.
If a layout wants to provide an additional screen for a desktop in the secondary
screen, it should specify the screen.
Details
Details
- Reviewers
mart - Group Reviewers
Plasma - Commits
- R871:c79cfed9b762: Consider the primary screen as default screen
R871:d1210f5fda01: Consider the primary screen as default screen
R120:ab0958f55b40: Consider the primary screen as default screen
R120:c79cfed9b762: Consider the primary screen as default screen
R871:ab0958f55b40: Consider the primary screen as default screen
R120:d1210f5fda01: Consider the primary screen as default screen
R120:3ff2d8c72a1a: Consider the primary screen as default screen
Now the plasmashell tests pass. In fact I noticed it was broken due to an e-mail
Jonathan sent me that the test on neon was timing out. The test in neon will
freeze when the test crashes. Probably something to look into.
It can be reproduced by running:
xvfb-run -a --server-args="-screen 0 1024x768x24" dbus-launch --exit-with-session <exec>
Where exec is the process we need to run.
Now the test passes.
It's a crash that I had reproduced locally in the past. I can't now.
Diff Detail
Diff Detail
- Repository
- R120 Plasma Workspace
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
This doesn't seem to have helped, this build has been going for an hour
http://build.neon.kde.org/job/xenial_stable_plasma_plasma-workspace_adt/28/consoleFull