Consider the primary screen as default screen
ClosedPublic

Authored by apol on Jul 8 2016, 11:00 AM.

Details

Summary

We used to append them, but that didn't work well and was crashing plasmashell
on fresh start.
A default desktop would be created alongside with the one provided by the
layout instead of replacing it.
If a layout wants to provide an additional screen for a desktop in the secondary
screen, it should specify the screen.

Test Plan

Now the plasmashell tests pass. In fact I noticed it was broken due to an e-mail
Jonathan sent me that the test on neon was timing out. The test in neon will
freeze when the test crashes. Probably something to look into.
It can be reproduced by running:

xvfb-run -a --server-args="-screen 0 1024x768x24" dbus-launch --exit-with-session <exec>

Where exec is the process we need to run.

Now the test passes.
It's a crash that I had reproduced locally in the past. I can't now.

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
apol updated this revision to Diff 5016.Jul 8 2016, 11:00 AM
apol retitled this revision from to Consider the primary screen as default screen.
apol updated this object.
apol edited the test plan for this revision. (Show Details)
apol added a reviewer: Plasma.
apol added a subscriber: Neon.
Restricted Application added a project: Plasma. · View Herald TranscriptJul 8 2016, 11:00 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

This doesn't seem to have helped, this build has been going for an hour
http://build.neon.kde.org/job/xenial_stable_plasma_plasma-workspace_adt/28/consoleFull

apol added a comment.Jul 11 2016, 4:35 PM

You mean you applied the patch?

mart accepted this revision.Jul 11 2016, 6:25 PM
mart added a reviewer: mart.
This revision is now accepted and ready to land.Jul 11 2016, 6:25 PM
This revision was automatically updated to reflect the committed changes.