Differential D21108

Fix build error in uploaddialog.ui
ClosedPublic
Actions

Authored by nicolasfella on May 9 2019, 9:07 PM.

Details

Reviewers
dhaumann
gregormi
ngraham
apol
Group Reviewers
Frameworks
Commits
R304:90eff8941be8: Fix build error in uploaddialog.ui
Summary

Building againt current Qt dev fails:

In file included from /home/nico/kde/src/knewstuff/src/uploaddialog_p.h:22,
 from /home/nico/kde/src/knewstuff/src/uploaddialog.cpp:22:
/home/nico/kde/build/knewstuff/src/ui_uploaddialog.h: In member function ‘void Ui_UploadDialog::setupUi(QWidget*)’:
/home/nico/kde/build/knewstuff/src/ui_uploaddialog.h:173:36: error: no matching function for call to ‘QLineEdit::setEchoMode(bool)’
         password->setEchoMode(false);
                                    ^

Using enum instead of bool fixes it

Test Plan

Builds

Diff Detail

Repository
R304 KNewStuff
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
nicolasfella created this revision.May 9 2019, 9:07 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptMay 9 2019, 9:07 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
nicolasfella requested review of this revision.May 9 2019, 9:07 PM
ngraham accepted this revision.May 9 2019, 9:54 PM
This revision is now accepted and ready to land.May 9 2019, 9:54 PM
apol accepted this revision.May 9 2019, 11:11 PM
apol added a subscriber: apol.

weeeeeeeeeeeeird
How was this <bool> ever generated? :|

Closed by commit R304:90eff8941be8: Fix build error in uploaddialog.ui (authored by nicolasfella). · Explain WhyMay 9 2019, 11:23 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/uploaddialog.ui (2 lines)

Diff 57827

View Options

src/uploaddialog.ui

Loading...