Differential D21069

[RFC] Improve documentation of Document::setPageTextSelection()
ClosedPublic
Actions

Authored by davidhurka on May 7 2019, 10:49 AM.

Details

Reviewers
aacid
Group Reviewers
Okular
Commits
R223:9791d2591689: Improve documentation of Document::setPageTextSelection()
Summary

Improve the documentation of Document::setPageTextSelection()
and PagePrivate::setTextSelections(). Also mention which argument
will be deleted.

Test Plan

Check doxygen output

Diff Detail

Repository
R223 Okular
Branch
improve-documentation-of-setpagetextselection (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 11632
Build 11650: arc lint + arc unit
davidhurka created this revision.May 7 2019, 10:49 AM
Restricted Application added a project: Okular. · View Herald TranscriptMay 7 2019, 10:49 AM
Restricted Application added a subscriber: okular-devel. · View Herald Transcript
davidhurka requested review of this revision.May 7 2019, 10:49 AM
davidhurka added a comment.May 7 2019, 11:13 AM

I suggested this in D18744#441906.

It would be more natural not to delete rect, because that causes a dangling pointer, and makes the calling code look memory leaking.

I’m new with submitting patches, so feel free to correct anything.

aacid accepted this revision.May 8 2019, 11:13 PM
This revision is now accepted and ready to land.May 8 2019, 11:13 PM
Closed by commit R223:9791d2591689: Improve documentation of Document::setPageTextSelection() (authored by davidhurka, committed by sander). · Explain WhyMay 9 2019, 8:50 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mcore/document.h (4 lines)
Mcore/page_p.h (7 lines)

Diff 57709

View Options

core/document.h

Loading...
View Options

core/page_p.h

Loading...