[RFC] Improve documentation of Document::setPageTextSelection()
ClosedPublic

Authored by davidhurka on May 7 2019, 10:49 AM.

Details

Summary

Improve the documentation of Document::setPageTextSelection()
and PagePrivate::setTextSelections(). Also mention which argument
will be deleted.

Test Plan

Check doxygen output

Diff Detail

Repository
R223 Okular
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidhurka created this revision.May 7 2019, 10:49 AM
Restricted Application added a project: Okular. · View Herald TranscriptMay 7 2019, 10:49 AM
Restricted Application added a subscriber: okular-devel. · View Herald Transcript
davidhurka requested review of this revision.May 7 2019, 10:49 AM

I suggested this in D18744#441906.

It would be more natural not to delete rect, because that causes a dangling pointer, and makes the calling code look memory leaking.

I’m new with submitting patches, so feel free to correct anything.

aacid accepted this revision.May 8 2019, 11:13 PM
This revision is now accepted and ready to land.May 8 2019, 11:13 PM
This revision was automatically updated to reflect the committed changes.