The action buttons were missing a visual indication of when they were being pressed so this patch adds it by drawing another an animated rectangle when the button is pressed.
Details
Details
- Reviewers
ngraham davidedmundson - Group Reviewers
VDG Plasma - Commits
- R120:eaa5f94c0584: [Lock, login & logout screen] Add visual feedback to action buttons when pressed
Diff Detail
Diff Detail
- Repository
- R120 Plasma Workspace
- Branch
- add-pressed-state-to-action-buttons (branched from master)
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 11649 Build 11667: arc lint + arc unit
Comment Actions
Looks lovely!
| lookandfeel/contents/components/ActionButton.qml | ||
|---|---|---|
| 69 ↗ | (On Diff #57699) | This item isn't referenced, so it doesn't need to have an id |
| 71 ↗ | (On Diff #57699) | Are you sure you can assign undefined to this? (Good catch using containsPress instead of pressed! to match proper button behavior! :) |
| 76 ↗ | (On Diff #57699) | Can't you just scale the item instead of animating its width and height since the item is always "square" anyway |
Comment Actions
I'm going to look into the different easing curves a bit more because I sometimes see the semi-scaled circle if clicking too fast.
| lookandfeel/contents/components/ActionButton.qml | ||
|---|---|---|
| 76 ↗ | (On Diff #57699) | Using scale now instead of messing with height and width, thanks for the tip :) |
Comment Actions
Here's what I'm trying to avoid:
When pressing fast and in the lock screen we can see the circle is still in the process of being scaled to 1. I have some easing types shortlisted which behave better than InOutQuad, but have to do round 2 of testing.
Comment Actions
- change easing type from InOutQuad to InOutQuart to improve behavior when clicked fast
- shorten the animation for the same reason