add multiple gestures and a handler class to KWidgetsAddons
Needs ReviewPublic

Authored by steffenh on May 5 2019, 6:50 AM.


Group Reviewers

This patch adds the gestures and handler class from gwenview to KWidgetsAddons, so another program you can use this.

Diff Detail

R236 KWidgetsAddons
No Linters Available
No Unit Test Coverage
Build Status
Buildable 11915
Build 11933: arc lint + arc unit
steffenh created this revision.May 5 2019, 6:50 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptMay 5 2019, 6:50 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
steffenh requested review of this revision.May 5 2019, 6:50 AM
cfeck added a subscriber: cfeck.May 5 2019, 7:28 AM

Did you try to submit the additional gesture types to Qt? We should only add them here if they rejected the idea to add new types in Qt.

apol added a subscriber: apol.May 5 2019, 10:12 PM

It could make sense to run clazy on these, I'm pretty sure we'd find interesting stuff.


Why is this commented out?


If classes are installed and exported they should have a d-pointer.

Hi @apol,

Thanks for your time to look at my code. I know, I'am not good at this, so if you can point me at my errors I will try to correct this.


Oops this should not be here, it is a left over from gwenview.


Ok, I will add a private class for all exported classes.

Hi @nicolasfella,

Ok, I need a new name, perhaps KGesture ?

ngraham added a subscriber: ngraham.May 8 2019, 2:01 PM

Here's a tip: you can use to search for existing class names and identifiers.

Hi @ngraham,

thanks for the link, I see KGesture is already used. I hope KGestureHandler is not too similar

Since these are touch-only, maybe KTouchGesture or KTouchHandler?

steffenh updated this revision to Diff 58241.May 18 2019, 10:04 AM

change name to KTouchGesture
add a private class for every exported class
remove unused code