Differential D20979

[WidgetFactory] Move isLocalFile() check, toLocalFile() to setters
ClosedPublic
Actions

Authored by bruns on May 2 2019, 11:50 PM.

Details

Reviewers
astippich
ngraham
Group Reviewers
Baloo
Commits
R824:a89f12605f08: [WidgetFactory] Move isLocalFile() check, toLocalFile() to setters
Summary

Avoid converting the KFileItem to a path for the common case of only
showing the file attributes.
This is the first/preparatory part.

Diff Detail

Repository
R824 Baloo Widgets
Branch
check_edit
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 11470
Build 11488: arc lint + arc unit
bruns created this revision.May 2 2019, 11:50 PM
Restricted Application added a project: Baloo. · View Herald TranscriptMay 2 2019, 11:50 PM
bruns requested review of this revision.May 2 2019, 11:50 PM
astippich accepted this revision.May 3 2019, 4:39 PM
This revision is now accepted and ready to land.May 3 2019, 4:39 PM
Closed by commit R824:a89f12605f08: [WidgetFactory] Move isLocalFile() check, toLocalFile() to setters (authored by bruns). · Explain WhyMay 3 2019, 5:22 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/filemetadatawidget.cpp (4 lines)
Msrc/widgetfactory.h (4 lines)
Msrc/widgetfactory.cpp (26 lines)

Diff 57424

View Options

src/filemetadatawidget.cpp

Loading...
View Options

src/widgetfactory.h

Loading...
View Options

src/widgetfactory.cpp

Loading...