[WidgetFactory] Move isLocalFile() check, toLocalFile() to setters
ClosedPublic
Actions

Authored by bruns on May 2 2019, 11:50 PM.

Details

Reviewers

astippich
ngraham

Group Reviewers

Baloo

Commits

Summary

Avoid converting the KFileItem to a path for the common case of only
showing the file attributes.
This is the first/preparatory part.

Repository

R824 Baloo Widgets

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

bruns requested review of this revision.May 2 2019, 11:50 PM

This revision is now accepted and ready to land.May 3 2019, 4:39 PM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			src/filemetadatawidget.cpp (4 lines)
M			src/widgetfactory.h (4 lines)
M			src/widgetfactory.cpp (26 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	57424	9bff3f8		May 2 2019, 11:50 PM	★	★
Diff 2	57487	d04e928	R824:a89f12605f089fedd8cc36588767446564ffe067	May 3 2019, 5:22 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
7d490f2b4cd5	c2993dd08a43	9bff3f8b2271	Stefan Brüns	[WidgetFactory] Move isLocalFile() check, toLocalFile() to setters (Show More…)	May 2 2019, 10:16 PM

Status	Author	Revision
Closed	bruns	D20981 [FileMetaDataProvider] Actually check if the file can be modified
Closed	bruns	D20980 [FileMetaDataProvider] Move readOnly check into the fetch jobs
Closed	bruns	D20979 [WidgetFactory] Move isLocalFile() check, toLocalFile() to setters