nrother (Nils Rother)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Mar 4 2019, 12:54 PM (36 w, 1 d)
Availability
Available

Recent Activity

Apr 12 2019

nrother added a comment to D19591: Add Compression Quality slider for lossy formats.

I looked into Qt and it actually uses compression. It just falls back to quality if compression is not set. See: https://code.qt.io/cgit/qt/qtbase.git/tree/src/gui/image/qpnghandler.cpp#n1075
I did a quick test P367 and it seems to work. The question now is do we want to special case this for png to not accidentally break another format (would be a quick fix) or to enable it for all formats that support it. In my opinion if we do the latter we should now do testing (maybe automated?) to not run into weird quality/compression interactions for other formats.
@nrother Do you want to fix it for 19.04.1?

Apr 12 2019, 10:37 AM · Spectacle

Apr 3 2019

nrother added a comment to D19591: Add Compression Quality slider for lossy formats.

It seems for the png implementation setQuality also sets the Compression instead of setCompression:
https://bugreports.qt.io/browse/QTBUG-43618

Apr 3 2019, 10:47 AM · Spectacle
nrother added a comment to D19591: Add Compression Quality slider for lossy formats.

Where is the check that this is done only for lossy formats? Here, PNG is saved uncompressed after this change.

Apr 3 2019, 10:34 AM · Spectacle

Mar 7 2019

nrother added a comment to D19591: Add Compression Quality slider for lossy formats.

Now that you're familiar with how to do this, would you like to take a crack at doing the same for Gwenview?

https://bugs.kde.org/show_bug.cgi?id=277996

Mar 7 2019, 8:43 PM · Spectacle
nrother updated the diff for D19591: Add Compression Quality slider for lossy formats.

Adjust codestyle

Mar 7 2019, 7:38 PM · Spectacle
nrother updated the diff for D19591: Add Compression Quality slider for lossy formats.

Use lambda expression to update quality label so it doesn't need to be a member variable

Mar 7 2019, 6:46 PM · Spectacle
nrother added a comment to D19591: Add Compression Quality slider for lossy formats.

Oh I see what you mean. It's very subtle. Probably an issue in Qt unfortunately. :(

...Which is good for this patch, since it means there's probably nothing we can do here. Please do file a bug though: https://bugreports.qt.io/secure/CreateIssue!default.jspa

Mar 7 2019, 5:47 PM · Spectacle
nrother added a comment to D19591: Add Compression Quality slider for lossy formats.

I can't reproduce the washed-out image effect. Here's the same image saved four times at various different file formats and compression levels:

Mar 7 2019, 5:36 PM · Spectacle
nrother updated the diff for D19591: Add Compression Quality slider for lossy formats.

Add help-text for quality-slider

Mar 7 2019, 5:13 PM · Spectacle
nrother updated the diff for D19591: Add Compression Quality slider for lossy formats.

Adjust slider position

Mar 7 2019, 4:58 PM · Spectacle
nrother added a comment to D19591: Add Compression Quality slider for lossy formats.

Something like this (quick copy & paste job):

Mar 7 2019, 3:57 PM · Spectacle
nrother added a comment to D19591: Add Compression Quality slider for lossy formats.

I think the slider looks a bit disconnected to the file format maybe putting it below the Filename and format would work.

I'm not sure I understand where exactly you mean? I feel the current position makes sense because the other two fields are both
related to WHERE the file is saved, whereas this new option is about HOW this file is saved, so it should be separate from those two.

Mar 7 2019, 3:21 PM · Spectacle
nrother added a reviewer for D19591: Add Compression Quality slider for lossy formats: Spectacle.
Mar 7 2019, 12:48 PM · Spectacle
nrother updated the test plan for D19591: Add Compression Quality slider for lossy formats.
Mar 7 2019, 12:47 PM · Spectacle
nrother requested review of D19591: Add Compression Quality slider for lossy formats.
Mar 7 2019, 12:46 PM · Spectacle

Mar 6 2019

nrother added a comment to D19525: Add option to auto-accept box selection on mouse release.

Since I know you use a dual screen setup, for your next trick would you like to have a crack at https://bugs.kde.org/show_bug.cgi?id=385885?

Mar 6 2019, 6:58 PM · Spectacle
nrother updated the diff for D19525: Add option to auto-accept box selection on mouse release.

Adjust help-text to be more contextual and improve the new settings' description

Mar 6 2019, 4:54 PM · Spectacle

Mar 5 2019

nrother added a comment to D19525: Add option to auto-accept box selection on mouse release.

Okay, here's the new option text:

Mar 5 2019, 12:13 PM · Spectacle

Mar 4 2019

nrother added a comment to D19525: Add option to auto-accept box selection on mouse release.

Yep, that one. When accept-on-click-and-release is being used, and one of the "remember the region" modes is NOT being used, we should make the text just say something like "Click and drag to select the desired region", because everything else pertains to manipulating the region. But when accept-on-click-and-release and one of the "remember the region" modes IS being used, then we should just change "Enter, double-click:" to "Click and drag, Enter, double-click:"

Does that make sense?

Mar 4 2019, 11:08 PM · Spectacle
nrother added a comment to D19525: Add option to auto-accept box selection on mouse release.

Sweet, that was fast!

Let's make sure to update the explanatory text appropriately when this mode is being used--including in conjunction with remembered regions.

Mar 4 2019, 10:35 PM · Spectacle
nrother updated the test plan for D19525: Add option to auto-accept box selection on mouse release.
Mar 4 2019, 8:34 PM · Spectacle
nrother added a reviewer for D19525: Add option to auto-accept box selection on mouse release: Spectacle.
Mar 4 2019, 8:31 PM · Spectacle
nrother updated the test plan for D19525: Add option to auto-accept box selection on mouse release.
Mar 4 2019, 8:30 PM · Spectacle
nrother requested review of D19525: Add option to auto-accept box selection on mouse release.
Mar 4 2019, 8:28 PM · Spectacle
nrother added a comment to D19515: Fix recangle-selection help-text positioning .

Only when you use the arc command-line tool to submit the patch, I'm afraid. For more information, see https://community.kde.org/Infrastructure/Phabricator#Using_Arcanist_to_post_patches

Mar 4 2019, 5:10 PM · Spectacle
nrother added a comment to D19515: Fix recangle-selection help-text positioning .

Thanks, this is perfect!

Can you provide your full name and email address so I can land this patch with correct authorship information?

Mar 4 2019, 4:37 PM · Spectacle
nrother requested review of D19515: Fix recangle-selection help-text positioning .
Mar 4 2019, 2:57 PM · Spectacle