No functional changes
Details
Details
- Reviewers
nicolasfella astippich ngraham elvisangelaccio - Group Reviewers
Baloo Dolphin - Commits
- R824:fe8ff6c2e113: Remove Q_FOREACH, reserve space in destination list
compiles
Diff Detail
Diff Detail
- Repository
- R824 Baloo Widgets
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
| src/filemetadataprovider.cpp | ||
|---|---|---|
| 336 | It is probably not a big deal, but if the url is not a local file, this would over-allocate, wouldn't it? | |
| src/filemetadataprovider.cpp | ||
|---|---|---|
| 336 | Yes, but a) its a temporary, b) its an order of magnitude smaller than m_fileitems itself, c) not reserving typically overallocates as well (non-linear grows), and when resizing you need memory for the old and the new list. | |