Differential D20864

[MetadataProvider] Use fixed order for modified/accessed/created
ClosedPublic
Actions

Authored by bruns on Apr 27 2019, 12:22 PM.

Details

Reviewers
meven
ngraham
astippich
Group Reviewers
Baloo
Dolphin
Commits
R824:9cda8c72b824: [MetadataProvider] Use fixed order for modified/accessed/created
Summary

The widget concatenates the group and the translated label to determine
the sort order. Using the same group for modified/accessed/created makes
the order dependent on the translated label.

Diff Detail

Repository
R824 Baloo Widgets
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
bruns created this revision.Apr 27 2019, 12:22 PM
Restricted Application added a project: Baloo. · View Herald TranscriptApr 27 2019, 12:22 PM
bruns requested review of this revision.Apr 27 2019, 12:22 PM
astippich accepted this revision.Apr 27 2019, 1:21 PM
This revision is now accepted and ready to land.Apr 27 2019, 1:21 PM
meven accepted this revision.Apr 27 2019, 1:47 PM
Closed by commit R824:9cda8c72b824: [MetadataProvider] Use fixed order for modified/accessed/created (authored by bruns). · Explain WhyApr 27 2019, 2:32 PM
This revision was automatically updated to reflect the committed changes.
elvisangelaccio added a subscriber: elvisangelaccio.Apr 28 2019, 10:54 AM

Can you please push this fix to the Applications/19.04 branch too?

bruns added a comment.Apr 28 2019, 11:28 AM
In D20864#457402, @elvisangelaccio wrote:

Can you please push this fix to the Applications/19.04 branch too?

This was only added for 19.07.70, so does not apply.

elvisangelaccio added a comment.Apr 28 2019, 11:35 AM

Ah right, sorry for the noise.

bruns added a comment.Apr 28 2019, 11:37 AM

No worries ;-)

Revision Contents
Changeset List

PathPackages
Msrc/filemetadataprovider.cpp (10 lines)

Diff 57107

View Options

src/filemetadataprovider.cpp

Loading...