Differential D20827

Reword some text, a couple clean ups, add a separator
ClosedPublic
Actions

Authored by meven on Apr 25 2019, 6:57 PM.

Details

Reviewers
ngraham
GB_2
Group Reviewers
Frameworks
VDG
Commits
R241:f17749e70c09: Reword some text, a couple clean ups, add a separator
Summary

Re-word some menu items per T8552#140370

Test Plan

before:

after

Diff Detail

Repository
R241 KIO
Branch
rewored
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 11234
Build 11252: arc lint + arc unit
meven created this revision.Apr 25 2019, 6:57 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptApr 25 2019, 6:57 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
meven requested review of this revision.Apr 25 2019, 6:57 PM
meven edited the test plan for this revision. (Show Details)Apr 25 2019, 6:58 PM
meven added a reviewer: ngraham.
ngraham accepted this revision.Apr 25 2019, 7:13 PM
This revision is now accepted and ready to land.Apr 25 2019, 7:13 PM
GB_2 accepted this revision.Apr 25 2019, 7:21 PM
GB_2 added reviewers: Frameworks, VDG.
GB_2 added a project: VDG.
Closed by commit R241:f17749e70c09: Reword some text, a couple clean ups, add a separator (authored by meven). · Explain WhyApr 25 2019, 7:47 PM
This revision was automatically updated to reflect the committed changes.
meven added a comment.Apr 29 2019, 7:58 AM
In D20827#457391, @elvisangelaccio wrote:

@meven FYI this change broke the Frameworks string freeze: https://community.kde.org/Schedules/Frameworks

Should I revert this then ?

elvisangelaccio added a comment.May 1 2019, 5:08 PM
In D20827#457777, @meven wrote:
In D20827#457391, @elvisangelaccio wrote:

@meven FYI this change broke the Frameworks string freeze: https://community.kde.org/Schedules/Frameworks

Should I revert this then ?

Someone could have already started to translate these new strings. Just keep it in mind for the next time ;)

Revision Contents
Changeset List

Diff 56988

View Options

src/filewidgets/kdiroperator.cpp

Loading...
View Options

src/filewidgets/kfilewidget.cpp

Loading...