[WIP] Configure Konsole dialog GUI redesign
Needs ReviewPublic

Authored by mglb on Thu, Apr 25, 2:38 PM.

Details

Reviewers
ngraham
Group Reviewers
Konsole
VDG
Summary
  • Extensions/workarounds for KF5 classes - I'll fix the classes in KF5 later. This allows to make it work for now.
    • Create new KConfigDialog-like class and use it to show existing configuration pages.
    • Create KConfigDialogManager-like class for managing QButtonGroups
  • Remove help button from configuration dialog. There is nothing about configuration dialog options in the help.
  • Rename "File Location" to "Temporary Files" - this page probably will be removed (D20466)
    • Enable path selector only when "custom" is selected
    • Place paths directly in labels
  • Disable all tabbar settings except visibility when visibility is set to "Never"
  • Profile Settings
    • Use QTreeView instead of QTableView - it highlights whole lines, aligns header names to the left, etc. Basically it looks like lists in file manager or e.g. plugin list in Kate.
    • Use (default) QStyledItemDelegate with checkbox instead of custom delegate (tick mark) in favorite/show column. I like this look, but there is a task to standardize list views, so it will probably be changed in future anyway (T10384)
    • Change default profile item style - it now has italics font and "(default)" suffix.
    • Disable "Delete" button when default profile is selected
  • Minor string changes

TODO

  • Fix shortcuts for invisible profiles (in separate commit) or restore the label on profiles page
  • Profile lists changes (show/hide, remove and maybe create) should be applied after clicking apply or ok. This will make it consistent with other options, and make accidental profile removal reversible
  • Experiment with embedded edit profile dialog on profiles page and see if it makes sense
  • Cleanup

Screenshots





BUG: 404096
FIXED-IN: 19.08.0

Diff Detail

Repository
R319 Konsole
Branch
wip/Configure-Konsole-dialog-GUI-redesing (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 11545
Build 11563: arc lint + arc unit
mglb created this revision.Thu, Apr 25, 2:38 PM
Restricted Application added a subscriber: konsole-devel. · View Herald TranscriptThu, Apr 25, 2:38 PM
mglb requested review of this revision.Thu, Apr 25, 2:38 PM
mglb edited the summary of this revision. (Show Details)Thu, Apr 25, 2:38 PM
mglb edited the summary of this revision. (Show Details)Thu, Apr 25, 2:48 PM
  1. "Rename "File Location" to "Temporary Files" - this page probably will be removed (D20466)" - This isn't going to be removed - there are valid reasons to allow users to change the file locations.
  2. The Manage Profile page still needs the info 'The Show column must be checked for these shortcuts to work' until it gets fixed.

Try to make the commit lines < 72 - I know phabracitor doesn't help w/ this but it makes the commit message look better. Hopefully github changes will make this easier.

This looks really good - very nice job.

I think a lot of the info in the file location needs to be carried over.

ngraham requested changes to this revision.Fri, Apr 26, 3:28 PM
ngraham added a subscriber: ngraham.

Totally awesome. Some VDG-ish comments from a first pass:

src/settings/GeneralSettings.ui
93

I'd just go with "Case sensitive"; that it's about the search is already communicated by the left header.

106

Remove "by default"; this is implied by the fact that it's in a settings window

122

Maybe something shorter like "Remember window size" would work better?

171

The word "search" is now redundant here; let's change it to "Highlight all matches"

src/settings/TabBarSettings.ui
51

The default option for a set of radio buttons should be the first one; let's move this to the top

84

The default option for a set of radio buttons should be the first one; let's move this to the top

This revision now requires changes to proceed.Fri, Apr 26, 3:28 PM
ngraham edited the summary of this revision. (Show Details)Mon, Apr 29, 9:01 PM
mglb added a comment.Fri, May 3, 8:19 AM
  1. "Rename "File Location" to "Temporary Files" - this page probably will be removed (D20466)" - This isn't going to be removed - there are valid reasons to allow users to change the file locations.

I mean removed from this dialog - it is moved to the profile dialog in mentioned diff. Until then it stays here.

  1. The Manage Profile page still needs the info 'The Show column must be checked for these shortcuts to work' until it gets fixed.

    Try to make the commit lines < 72 - I know phabracitor doesn't help w/ this but it makes the commit message look better. Hopefully github changes will make this easier.

Sure, this is just a wip message, final one will be formatted

mglb updated this revision to Diff 57560.Sat, May 4, 4:54 PM
mglb marked 5 inline comments as done.
mglb edited the summary of this revision. (Show Details)

Fix issues from Nate's comments

mglb marked an inline comment as done.Sat, May 4, 4:54 PM
  1. The Manage Profile page still needs the info 'The Show column must be checked for these shortcuts to work' until it gets fixed.

I'll look at this

Try to make the commit lines < 72 - I know phabracitor doesn't help w/ this but it makes the commit message look better. Hopefully github changes will make this easier.

Try this with some browser extension for custom CSS:

.remarkup-assist-textarea {
    background: linear-gradient(to right,
      #fff    calc(72ch + 6px),
      #DDE8EF calc(72ch + 6px),
      #DDE8EF calc(72ch + 7px),
      #F8F9FC calc(72ch + 7px)
    );
    font-family: "Ubuntu Mono";
    font-size: 9pt;
    line-height: 1em;
}

So close from my perspective! Just two more little things I noticed:

src/MainWindow.cpp
745

While you're at it, let's change this to the grammatically correct string "Tab Bar".

src/settings/TabBarSettings.ui
288

Probably just "Show:" is fine here, since the whole page is about the tab bar.