Avoids introspection calls when creating the manager or devices.
Also drop codepath for old UPower, according to their git, the interface hasn't changed since 2015 (that's as far back as the history went, I didn't go any further) so I think it's safe to assume everyone uses an upower version that has this.
Details
Details
- Reviewers
davidedmundson bruns - Group Reviewers
Frameworks
Unless that special "last non-systemd version" some distros use is older than this?
- Plugged in my mouse, showed up, plugged it out, disappeared
- I shall test with my laptop whether the battery property changes are detected properly
Diff Detail
Diff Detail
- Repository
- R245 Solid
- Lint
Lint Skipped - Unit
Unit Tests Skipped
Comment Actions
UPower already installs the xml files. Wouldn't it be better to use the installed xml instead of providing our own?
| src/solid/devices/backends/upower/upowerdevice.cpp | ||
|---|---|---|
| 35 | unneeded? | |
Comment Actions
We copy udisks xml already. I don't think it ends up any better. Otherwise we have a compile time dep on a runtime plugin, which inevitably means we need to make it optional which only introduces more real-world bugs. It also means future devs know what we were compiled against.
Marking as requesting changes for the extra include, but personally I think it's generally good to go.
Comment Actions
We are also already copying part of the interface specification. After all, indexOfSignal("DeviceAdded(QDBusObjectPath)") is the same as the corresponding code generated by dbusxml2cpp.
Two more change requests:
- Please mention support for the deprecated DeviceAdded(string) (upower < 0.99) is removed
- Please wrap long lines in the summary etc.