Differential D20620

[balooctl] Switch multiline output to new helper
ClosedPublic
Actions

Authored by bruns on Apr 16 2019, 10:37 PM.

Details

Reviewers
ngraham
astippich
poboiko
Group Reviewers
Baloo
Frameworks
Commits
R293:812523dfd960: [balooctl] Switch multiline output to new helper
Summary

Output is mostly unchanged, but symlinks are no longer shown
as "Basic Indexing: Scheduled."

Depends on D20617.

Test Plan

balooctl status <file>

Diff Detail

Repository
R293 Baloo
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
bruns created this revision.Apr 16 2019, 10:37 PM
Restricted Application added projects: Frameworks, Baloo. · View Herald TranscriptApr 16 2019, 10:37 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
bruns requested review of this revision.Apr 16 2019, 10:37 PM
ngraham added inline comments.Apr 17 2019, 4:33 PM
src/tools/balooctl/statuscommand.cpp
150

Do we have to use auto here and below?

bruns added inline comments.Apr 18 2019, 12:23 AM
src/tools/balooctl/statuscommand.cpp
150

We hardly ever have to, but I see no reason why an explicit type would be helpful here. You wouldn't have objected if I had used auto filenameIt = args.constBegin();, right?

ngraham accepted this revision.Apr 18 2019, 3:30 PM
This revision is now accepted and ready to land.Apr 18 2019, 3:30 PM
Closed by commit R293:812523dfd960: [balooctl] Switch multiline output to new helper (authored by bruns). · Explain WhyApr 18 2019, 3:43 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/tools/balooctl/statuscommand.cpp (79 lines)

Diff 56548

View Options

src/tools/balooctl/statuscommand.cpp

Loading...