Differential D20619

[balooctl] Use new helper in json output
ClosedPublic
Actions

Authored by bruns on Apr 16 2019, 10:30 PM.

Details

Reviewers
ngraham
astippich
poboiko
Group Reviewers
Baloo
Frameworks
Commits
R293:d0057aebd715: [balooctl] Use new helper in json output
Summary

The output is mostly the same, save for the following fixes:

  • symlinks are no longer listed as "indexing=basic, state=scheduled", but are omitted from output
  • in case "onlyBasicIndexing" is active, indexing now shows "basic" instead of "content"
  • excluded files are now "indexing=none, state=disabled" instead of "indexing=basic, state=disabled"

Depends on D20617

Test Plan

balooctl status -f json <file>

Diff Detail

Repository
R293 Baloo
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
bruns created this revision.Apr 16 2019, 10:30 PM
Restricted Application added projects: Frameworks, Baloo. · View Herald TranscriptApr 16 2019, 10:30 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
bruns requested review of this revision.Apr 16 2019, 10:30 PM
ngraham added inline comments.Apr 17 2019, 4:32 PM
src/tools/balooctl/statuscommand.cpp
226–250

Do we have to use auto here and below?

ngraham accepted this revision.Apr 18 2019, 3:30 PM
This revision is now accepted and ready to land.Apr 18 2019, 3:30 PM
Closed by commit R293:d0057aebd715: [balooctl] Use new helper in json output (authored by bruns). · Explain WhyApr 18 2019, 3:43 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/tools/balooctl/statuscommand.cpp (90 lines)

Diff 56547

View Options

src/tools/balooctl/statuscommand.cpp

Loading...