[balooctl] Extend options help text, improve error checking
ClosedPublic

Authored by bruns on Apr 11 2019, 12:58 AM.

Details

Summary

The "-i" option requires a valid deviceId from the "-d" option. Error
out early if it is missing. Also mention the fact in the help text.

Extend help text for the positional arguments, the files can be specified
as Urls, document IDs or inodes (with -i).

Move parsing of the -d and -i options out of the loops.

Diff Detail

Repository
R293 Baloo
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
bruns created this revision.Apr 11 2019, 12:58 AM
Restricted Application added projects: Frameworks, Baloo. · View Herald TranscriptApr 11 2019, 12:58 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
bruns requested review of this revision.Apr 11 2019, 12:58 AM
astippich accepted this revision.Apr 11 2019, 5:13 PM
This revision is now accepted and ready to land.Apr 11 2019, 5:13 PM
ngraham accepted this revision.Apr 11 2019, 5:25 PM

Aaargh, forgot to click submit.

bruns added a comment.Apr 11 2019, 6:35 PM

Aaargh, forgot to click submit.

There are some more still open: D20330, D20331, D20332 ;-)

This revision was automatically updated to reflect the committed changes.