Differential D20332

Ensure QFileInfo is valid for the first FilteredDirIterator entry
ClosedPublic
Actions

Authored by bruns on Apr 7 2019, 2:59 AM.

Details

Reviewers
ngraham
astippich
poboiko
Group Reviewers
Baloo
Frameworks
Commits
R293:899ed35c6872: Ensure QFileInfo is valid for the first FilteredDirIterator entry
Summary

FilteredDirIterator returns its own path for the first next() call. As
the fileInfo() from the underlying QDirIterator is only valid after
the QDirIterator::next() has been called, the first QFileInfo was the
default constructed one.

Initialize a proper QFileInfo() on m_firstItem, and use the QDirIterators
fileInfo() only for the subsequent ones.

Test Plan

make

Diff Detail

Repository
R293 Baloo
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
bruns created this revision.Apr 7 2019, 2:59 AM
Restricted Application added projects: Frameworks, Baloo. · View Herald TranscriptApr 7 2019, 2:59 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
bruns requested review of this revision.Apr 7 2019, 2:59 AM
ngraham accepted this revision.Apr 11 2019, 6:39 PM

Very nice.

This revision is now accepted and ready to land.Apr 11 2019, 6:39 PM
Closed by commit R293:899ed35c6872: Ensure QFileInfo is valid for the first FilteredDirIterator entry (authored by bruns). · Explain WhyApr 11 2019, 9:36 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 56020

View Options

src/file/filtereddiriterator.h

Loading...
View Options

src/file/filtereddiriterator.cpp

Loading...