Display the settings as List instead of Tab

Authored by tcanabrava on Apr 9 2019, 3:38 PM.



This makes konsole settings follow the KDE HIG

Diff Detail

R319 Konsole
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
tcanabrava created this revision.Apr 9 2019, 3:38 PM
Restricted Application added a project: Konsole. · View Herald TranscriptApr 9 2019, 3:38 PM
Restricted Application added a subscriber: konsole-devel. · View Herald Transcript
tcanabrava requested review of this revision.Apr 9 2019, 3:38 PM
ngraham accepted this revision.Apr 9 2019, 4:04 PM
ngraham added a subscriber: mglb.

Well, it's a start. :) To be fully HIG-compliant, the whole thing needs to go through something similar to D17244. IIRC @mglb said he was working on that. Any update on the status of that work, @mglb?

This revision is now accepted and ready to land.Apr 9 2019, 4:04 PM

too many things to fix here and there. :)

This revision was automatically updated to reflect the committed changes.
mglb added a comment.Apr 9 2019, 6:31 PM

I'm working on settings dialog, i'll try to upload a wip version this week. There is a problem with the fact that parts of KF5 are outdated, e.g. Kconfigdialog wraps every page in qscrollarea and kconfigdialogmanager does not support button groups.
I've (almost) implemented missing parts in Konsole for now and I'll fix it in KF5 later. The code in Konsole will allow to release it in 19.08 without bumping required kf5 version too high. When bumping will be ok it is easy to replace custom Konsole code with kf5 api.

Sounds great, thanks for the update!

In D20410#446936, @mglb wrote:

custom Konsole code

Missed a golden opportunity to say Kustom Konsole Kode :)