New fields accessed and created in dolphin/baloo-widgets information panel:
GUI: New fields accessed and created in dolphin/baloo-widgets information panel
CCBUG: 286689
Details
Details
Tested locally
Diff Detail
Diff Detail
- Repository
- R824 Baloo Widgets
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
Thanks! Please make the dependency explicit and bump the minimum Frameworks version to 5.58 in the CMakeLists.txt file, or else guard these with ifdefs.
Comment Actions
KDE Frameworks 5.58 is expected to be released on Sat May 11th, 2019.
Given this will ship in Applications 19/08, I would favor bumping the dependency, as it is easier on me and on the code.
Comment Actions
Thanks, please don't land this until Frameworks 5.58 is released and D20096 has landed. :)
Comment Actions
One thing that I would have wanted to do though, is mask by default the accessed time as it seems to me less useful for most users.
But this is handled by the baloofileinformationrc kconfig file.
I could add a check for when reading baloofileinformationrc, if "kfileitem#accessed" is missing add it as false, do nothing otherwise.
I don't know if there a better way to do this like a default baloofileinformationrc or that could be a distribution issue.
What do you think ?
| CMakeLists.txt | ||
|---|---|---|
| 11 ↗ | (On Diff #55837) | Actually, this is not necessary: You *should* check for KFileItem::time(which) != QDateTime()though |
| src/filemetadataprovider.cpp | ||
| 179 | item.time(...) may return QDateTime() (default initialized), depending on the filesystem. | |
Comment Actions
D20096 was merged, and now the patch does not even depend on KF5 5.58.
So I would consider it to be mergeable.
Comment Actions
one test is failing with this:
https://build.kde.org/job/Applications/job/baloo-widgets/job/kf5-qt5%20SUSEQt5.10/35/